-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Bugfix: kAddTo support for swap_axes. #9541
Conversation
@eric-haibin-lin Any chance we can get this in the next release? |
@tdomhan Could you amend the commit and add
at the bottom? |
Co-authored-by: Asmus Hetzel <ahhetzel@amazon.com>.
758e4f8
to
e1cb27e
Compare
yeah of course. I also wouldn't mind to close the PR and update the other PR. Just whatever solution gets the fix into the next release works for me :) |
@piiswrong |
Like my comments in #9495, we should also revise the test here (https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_operator.py#L361-L377) to add a test for “grad_req=addto”. You may refer to the test codes in https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_operator.py#L775-L781 |
I'm merging this because code freeze is today. Let's update tests later. @marcoabreu Please track this. We should actually test for addto for ALL operators automatically. |
Co-authored-by: Asmus Hetzel <ahhetzel@amazon.com>.
thanks for merging! I will try to create an appropriate test based on pointers from @sxjscience. |
Co-authored-by: Asmus Hetzel <ahhetzel@amazon.com>.
Co-authored-by: Asmus Hetzel <ahhetzel@amazon.com>.
Description
With this PR the swapaxes operator no longer ignores the req argument. Previously this silently lead to wrong gradients.
Checklist
Essentials
make lint
)