-
Notifications
You must be signed in to change notification settings - Fork 6.8k
add infer_type for regression ops, fix issues#9847 #9848
Conversation
How did unit test test_operator.py test_regression() test work without the error? |
Yes, please track down why the test did not catch this issue |
Unittest is written in symbolic mode while the issue is in imperative mode. In symbolic mode, infer_type pass has a default infer function |
By the way, |
Makes sense. |
Very nice catch, @ZiyueHuang! Sounds like a good idea. |
Please feel free to add infer type for the other ones if you like (not required for this PR, however). |
Is this good to merge? @piiswrong |
@piiswrong any special reason for missing default inference function in imperative mode? |
We can add a default for imperative later |
* add infer_type for regression ops * trigger CI
* add infer_type for regression ops * trigger CI
Description
fix #9847
Checklist
Essentials
make lint
)Changes
Comments