Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts! #514

werpu · 2023-02-10T09:05:35Z

I have to open another pull request on the same branch, because the original one has been showing a merge error for quite some time. The merge is imminent, I just want to run another set of TCKs tests with the latest codebase

…ES-4456

…ES-4456 # Conflicts: # api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js

* MYFACES-4468: Implement f:selectItemGroup * Create test for f:selectItemGroup * Resolve TCK signature failures (Remove Added Fields)

…ing import ranges in manifest

nonce handling in the new tests

integrated dom query sources, another fix for the nonce handling

updating from the github upstream project. Fix for an eval regression introduced by our nonce fixes (only the new codebase is affected) integratioin test 5, double eval failed because of it

updating to the latest mona-dish (no fixes but just to be in sync)

# Conflicts: # api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Dom.js # api/src/main/javascript/META-INF/resources/myfaces/_impl/core/_EvalHandlers.js # api/src/main/javascript/META-INF/resources/myfaces/_impl/core/_Runtime.js

merging t-andraschkos changes with mine on the TCK 790... All TCKs pass as good as on the master now! Also mergin in the latest fixes for bugs reported by Tobago in the JS codebase

…re/MYFACES-4466

# Conflicts: # api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js # impl/src/main/java/org/apache/myfaces/component/validate/ValidateWholeBeanComponent.java

Update to the latest cleaned up codebase XhrFormData noa finally in a state I can live with all tests pass TCK as well!

fixing a test

werpu · 2023-02-10T09:07:09Z

For the sake of documentation, I will close the old pull request, because it has been broken for quite a while.
So that nothing gets lost documentationwise, here is the link:
#356

(The old one will be closed now)

werpu · 2023-02-10T09:11:48Z

The failing test is invalid, it relies on the onerror handler being called if source is not set:
The spec states:

If the source element is null or undefined throw an error.

I also did a double check with a running mojarra server, and there also the onerror handler is not called for this case.
So the test passing a null as source element expecting the onerror handler to be called is wrong here. I will remove the testcase. It is not valid anymore! And the new implementation behaves 100% spec conform for this (and does the same as Mojarra)

removing an invalid test! (not spec conform and neither does mojarra behave like that)

werpu · 2023-02-10T10:17:44Z

TCKs pass, however the Tobago people reported an issue with the fileupload for the RC34 of the jsf_ts codebase which needs a fix, so no merge this week, RC33 worked, but I do not want to fork the codebase there.

Fixed I will rerun the TCKs now, hopefully for a last time before going into the merge!

Refixing the fileupload after a report by the Tobag guys.

werpu · 2023-02-10T11:31:47Z

Integration Tests pass:

TCK:
Faces40 / Ajax:

Faces 22

Faces 23/ajax:

Namespace:

Note originally in faces 23 Test 1423 was failing due to a race condition between webdriver and js engine execution, this is an issue of the test itself (timing issue, with a race condition between the webdriver and the test code, which is not fixable on framework level, but the test itself needs adaption)
The adapted test passes. I will issue a fix for the test on the TCK side on monday together with a small selenium test framework update!

Tobago guys also gave the ok... seems like we are set now...

I already am in the weekend, so I will merge monday!
This was a long one, but finally!

werpu · 2023-02-12T20:24:31Z

Hi bad news... i got a mild infection, and currently being in bed with fever, so I will leave the honor for the merge to @volosied, @tandraschko or @pnicolucci unless you want to wait until I have recovered (which might be wednesday)
Feel free to go ahead with the merge!

tandraschko · 2023-02-13T09:18:03Z

@werpu i did a small review again and looks good
i just wonder if you could give a small explantation about the server side changes?

but wednesday is enough, gute besserung :)

werpu · 2023-02-13T10:20:28Z

This is mostly a complexity reduction, because instead of 4-5 different target builds (without mapping files back then) we had in the original, we now have only two: production and development, but also we have mapping files. Thats all there is to it.

tandraschko · 2023-02-13T16:15:25Z

lets merge this
thanks for your great and hard work werner!

melloware · 2023-02-13T16:22:03Z

I will second that I know this was a LOT of work.

tandraschko · 2023-02-13T16:25:57Z

the build somehow fails on localhost:

myfaces.faces.ajax@1.0.0 test
env TS_NODE_PROJECT=./tsconfig-myfaces.json mocha

Der Befehl "env" ist entweder falsch geschrieben oder konnte nicht gefunden werden.

any idea?

werpu · 2023-02-13T17:57:54Z

@tandraschko thanks for the merge, this is a windows build issue, as it seems, which I have not caught upfront:

webpack/webpack.js.org#2733
Try the cross-env solution, if this fails I will work on this on wednesday when I am back.

You have to run an npm install first, it wont be there automatically: https://stackoverflow.com/questions/11928013/node-env-is-not-recognized-as-an-internal-or-external-command-operable-comman

Another option would be to detect the build os on programmatical level and set the environment vars accordingly. Either way if you cannot figure it out, then I will fix it Wednesday for you. Should not block the CI build which is running on a unixoid environment, but needs to be fixed, feel free to open a bug report and assign it to me.

werpu · 2023-02-15T06:30:28Z

@tandraschko could you resolve the issue? Otherwise I will look into it!

tandraschko · 2023-02-15T08:10:55Z

@werpu i didnt had the time
if you can "fix" our code, i can just do a mvn install again on my machine to test it

werpu · 2023-02-15T13:14:09Z

resolved it with @tandraschko, we can see the issue as closed now. The fix was indeed to use the cross-env package as replacement for the env command. I was not aware of the cross platform issues env in Node has and many people aren´t as it seems. Fix is merged by @tandraschko

werpu and others added 30 commits September 26, 2022 12:53

MYFACES-4466: Adding latest script version

c392c68

MYFACES-4466: Adding latest script version

71807df

Merge remote-tracking branch 'myfaces_gitlab/main' into feature/MYFAC…

314c2ad

…ES-4456

Merge remote-tracking branch 'myfaces_gitlab/main' into feature/MYFAC…

f91f493

…ES-4456 # Conflicts: # api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js

MYFACES-4468: Implement selectItemGroup (apache#326)

4fd91ce

* MYFACES-4468: Implement f:selectItemGroup * Create test for f:selectItemGroup * Resolve TCK signature failures (Remove Added Fields)

Update myfaces-ci.yml

b185dcf

fixed build

9b7680a

MYFACES-4471

9dbd455

Correct COMPONENT_FAMILY string for _UISelectItemGroups

a4ef26d

MYFACES-4447: avoid UnsupportedOperationException

0403f2e

MYFACES-4459 Update imports javax -> jakarta

137670f

Update EE depdendencies to latest

bcbd68c

Downgrade org.apache.felix:maven-bundle-plugin to 4.0.0 to avoid miss…

6015fd4

…ing import ranges in manifest

Add versions to imports; remove jsp/jstl imports from bundle pom

4de8047

MYFACES-4474: remove setType validation

b11c3fe

MYFACES-4476: updating to the latest jsf_js.ts codebase

1c317e9

MYFACES-4456: fixing checkstyle violation, and remove style warnings

a615762

MYFACES-4456: fixing a build issue in the server maven build

d5bb9e8

Merge branch 'main' into feature/MYFACES-4456

bb0500d

MYFACES-4456: fixing a build issue in the server maven build

5ccfef9

MYFACES-4456: fixing a build issue in the server maven build

e7d06b9

Merge branch 'main' into feature/MYFACES-4456

9dd90a1

https://issues.apache.org/jira/projects/MYFACES/issues/MYFACES-4479

bcf861c

nonce handling in the new tests

https://issues.apache.org/jira/browse/MYFACES-4479: updating the

a3f95f8

integrated dom query sources, another fix for the nonce handling

https://issues.apache.org/jira/browse/MYFACES-4456:

abfdabc

updating from the github upstream project. Fix for an eval regression introduced by our nonce fixes (only the new codebase is affected) integratioin test 5, double eval failed because of it

https://issues.apache.org/jira/browse/MYFACES-4456:

14d7841

updating to the latest mona-dish (no fixes but just to be in sync)

MYFACES-4480: Fix NullPointerException in TagAttributeImpl#getBoolean

60a1bf2

MYFACES-4484: Add forward slash to composite namespace

9ace74a

MYFACES-4466: Adding latest script version

5b67cce

werpu added 7 commits February 3, 2023 17:48

https://issues.apache.org/jira/browse/MYFACES-4533:

af5c935

merging t-andraschkos changes with mine on the TCK 790... All TCKs pass as good as on the master now! Also mergin in the latest fixes for bugs reported by Tobago in the JS codebase

https://issues.apache.org/jira/browse/MYFACES-4533:

2eb0040

merging t-andraschkos changes with mine on the TCK 790... All TCKs pass as good as on the master now! Also mergin in the latest fixes for bugs reported by Tobago in the JS codebase

Merge remote-tracking branch 'origin/feature/MYFACES-4466' into featu…

0cc384b

…re/MYFACES-4466

Merge remote-tracking branch 'origin/main' into feature/MYFACES-4466

8daa9da

# Conflicts: # api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js # impl/src/main/java/org/apache/myfaces/component/validate/ValidateWholeBeanComponent.java

https://issues.apache.org/jira/browse/MYFACES-4466:

854f1cc

Update to the latest cleaned up codebase XhrFormData noa finally in a state I can live with all tests pass TCK as well!

https://issues.apache.org/jira/browse/MYFACES-4466:

b75c550

fixing a test

Merge branch 'main' into feature/MYFACES-4466

cc6a123

werpu mentioned this pull request Feb 10, 2023

Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC4) #356

Closed

werpu requested review from tandraschko, volosied and bohmber February 10, 2023 09:08

werpu changed the title ~~Feature/myfaces 4466: Merge Pull request into main~~ Feature/myfaces 4466: Merge Pull request into main (RC5 Target) Feb 10, 2023

werpu changed the title ~~Feature/myfaces 4466: Merge Pull request into main (RC5 Target)~~ Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts! Feb 10, 2023

https://issues.apache.org/jira/browse/MYFACES-4466:

4d71b37

removing an invalid test! (not spec conform and neither does mojarra behave like that)

https://issues.apache.org/jira/browse/MYFACES-4466:

3e6b25a

Refixing the fileupload after a report by the Tobag guys.

tandraschko merged commit e4a4aff into apache:main Feb 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts! #514

Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts! #514

werpu commented Feb 10, 2023

werpu commented Feb 10, 2023

werpu commented Feb 10, 2023 •

edited

Loading

werpu commented Feb 10, 2023 •

edited

Loading

werpu commented Feb 10, 2023 •

edited

Loading

werpu commented Feb 12, 2023

tandraschko commented Feb 13, 2023 •

edited

Loading

werpu commented Feb 13, 2023 •

edited

Loading

tandraschko commented Feb 13, 2023

melloware commented Feb 13, 2023

tandraschko commented Feb 13, 2023

werpu commented Feb 13, 2023 •

edited

Loading

werpu commented Feb 15, 2023

tandraschko commented Feb 15, 2023

werpu commented Feb 15, 2023 •

edited

Loading

Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts! #514

Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts! #514

Conversation

werpu commented Feb 10, 2023

werpu commented Feb 10, 2023

werpu commented Feb 10, 2023 • edited Loading

werpu commented Feb 10, 2023 • edited Loading

werpu commented Feb 10, 2023 • edited Loading

werpu commented Feb 12, 2023

tandraschko commented Feb 13, 2023 • edited Loading

werpu commented Feb 13, 2023 • edited Loading

tandraschko commented Feb 13, 2023

melloware commented Feb 13, 2023

tandraschko commented Feb 13, 2023

werpu commented Feb 13, 2023 • edited Loading

werpu commented Feb 15, 2023

tandraschko commented Feb 15, 2023

werpu commented Feb 15, 2023 • edited Loading

werpu commented Feb 10, 2023 •

edited

Loading

werpu commented Feb 10, 2023 •

edited

Loading

werpu commented Feb 10, 2023 •

edited

Loading

tandraschko commented Feb 13, 2023 •

edited

Loading

werpu commented Feb 13, 2023 •

edited

Loading

werpu commented Feb 13, 2023 •

edited

Loading

werpu commented Feb 15, 2023 •

edited

Loading