Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Myfaces 4644 5.0 #650

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Myfaces 4644 5.0 #650

merged 2 commits into from
Dec 1, 2023

Conversation

volosied
Copy link
Contributor

@volosied volosied commented Nov 28, 2023

NonBinding isn't needed due to the regression mentioned below, but extension-less views for programmatic views now works.

@volosied
Copy link
Contributor Author

volosied commented Nov 29, 2023

I had been testing on 4.0 without the NonBinding attribute, but, then when I added it for 4.1 / 5.0, the tests start failing due to the NPE.

@tandraschko Any idea here?

Edit: I deleted my original comment as I thought it was wrong, but I think the idea there was correct.

Tests are resolving the facelets to ProgrammaticViewBean$$OwbNormalScopeProxy.

image

Do we need to select all beans annotated with @View and then filter then for the specific facelet now that the NonBinding is used?

@volosied
Copy link
Contributor Author

Build from scratch and, as suspected:

org.jboss.weld.exceptions.AmbiguousResolutionException: WELD-001318: Cannot resolve an ambiguous dependency between: 
  - Managed Bean [class com.example.HelloFacelet2] with qualifiers [@Any @View],
  - Managed Bean [class com.example.HelloFacelet] with qualifiers [@Any @View]
	at org.jboss.weld.manager.BeanManagerImpl.resolve(BeanManagerImpl.java:1139)
	at org.apache.myfaces.cdi.util.CDIUtils.get(CDIUtils.java:91)

@volosied volosied merged commit 61580b1 into apache:main Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants