-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/log: Add optional support for sector bookmarks to optimize reading logs #3365
Conversation
bf7d968
to
efdadf6
Compare
0e3bcee
to
142177c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code will not build for FCB2
- It's not clear how to choose size for bookmarks array
- If suggested size is around number of sector of the FCB flash area, RAM usage can be an issue. For 384 sectors' FCB RAM usage is over 12KB
- There are places that use code and RAM space even if no bookmarks/sector-bookmarks are enabled
3bcb976
to
8f26895
Compare
9611300
to
bd77e1c
Compare
Note: The style check incorrectly flags the unit test functions. It does not understand that its a function, it thinks its a code block. |
718acc3
to
b06037e
Compare
- Add sector bookmarks for reading optimization - Retain older absolute bookmarks behavior - CLI: Add '-t' option in log_shell for measuring read time (cherry-picking Jerzy's commit) - CLI: Add '-b' option in log_shell for reading bookmarks
2a90f33
to
c78d238
Compare
yes, there are couple of uncrustify config tuning needed that I haven't figure out yet (especially those related to macros as in here). So we hit false-positive with this from time to time... |
- Fix build, address some review comments
For mixed bookmarks:
0
->sector_cnt
of the flash area in the array.sector_cnt
->LOG_FCB_NUM_ABS_BMARKS
(2 by default)Several tests were performed: