porting/npl/linux: Handle EINTR from sem_timedwait #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanc
reviewed
Sep 6, 2024
porting/npl/linux/src/os_sem.c
Outdated
| return BLE_NPL_TIMEOUT; | ||
| while ((err = sem_timedwait(&sem->lock, &wait)) != 0) { | ||
| switch (errno) { | ||
| case EINTR: continue; |
There was a problem hiding this comment.
this should be
case EINTR:
continue;
case ETIMEDOUT:
return BLE_NPL_TIMEOUT;
I also wonder if there should be default case with assert maybe?
There was a problem hiding this comment.
fixed style.
in the default case we fall through to return BLE_NPL_ERROR and stack restart is attempted.
it happens to fail and assert but that's another story[1]. In theory a stack restart is the right thing to do in this case and might fix things.
[1] Assert happens here because ble_hs_sched_reset here bites on its own tail - tries to tx a reset command.
rojer
force-pushed
the
sem_timedwait_resume
branch
from
8dfc0af
to
cb88d6e
Compare
sjanc
approved these changes
Sep 6, 2024
It's been observed that `sem_timedwait()` can return `EINTR` even if `sigaction()` specified `SA_RESTART`. Not sure what the deal with that is but handling it is simple enough.
rojer
force-pushed
the
sem_timedwait_resume
branch
from
cb88d6e
to
1709b23
Compare
|
fixed whitespace, sorry |
|
no worries, and thanks for contributing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been observed that
sem_timedwait()can returnEINTReven ifsigaction()specifiedSA_RESTART.Not sure what the deal with that is but handling it is simple enough.