nimble/host: Truncate data in ble_eatt_tx #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#AutoPTS run mynewt GATT/SR |
|
Scheduled PR #1868 (comment), board: nrf52, estimated start time: 14:13:52, test case count: 68, estimated duration: 1:06:03 Test cases to be runGATT/SR/GAC/BV-01-CGATT/SR/GAC/BI-01-C GATT/SR/GAD/BV-01-C GATT/SR/GAD/BV-02-C GATT/SR/GAD/BV-03-C GATT/SR/GAD/BV-04-C GATT/SR/GAD/BV-05-C GATT/SR/GAD/BV-06-C GATT/SR/GAR/BV-01-C GATT/SR/GAR/BI-01-C GATT/SR/GAR/BI-02-C GATT/SR/GAR/BI-04-C GATT/SR/GAR/BI-05-C GATT/SR/GAR/BV-03-C GATT/SR/GAR/BI-06-C GATT/SR/GAR/BI-07-C GATT/SR/GAR/BI-08-C GATT/SR/GAR/BI-10-C GATT/SR/GAR/BI-11-C GATT/SR/GAR/BV-04-C GATT/SR/GAR/BI-12-C GATT/SR/GAR/BI-13-C GATT/SR/GAR/BI-14-C GATT/SR/GAR/BI-16-C GATT/SR/GAR/BI-17-C GATT/SR/GAR/BV-05-C GATT/SR/GAR/BI-18-C GATT/SR/GAR/BI-19-C GATT/SR/GAR/BI-21-C GATT/SR/GAR/BI-22-C GATT/SR/GAR/BV-06-C GATT/SR/GAR/BV-07-C GATT/SR/GAR/BV-08-C GATT/SR/GAR/BV-09-C GATT/SR/GAR/BV-11-C GATT/SR/GAR/BI-36-C GATT/SR/GAR/BI-38-C GATT/SR/GAR/BI-42-C GATT/SR/GAR/BI-44-C GATT/SR/GAR/BI-45-C GATT/SR/GAW/BV-01-C GATT/SR/GAW/BV-03-C GATT/SR/GAW/BI-02-C GATT/SR/GAW/BI-03-C GATT/SR/GAW/BI-05-C GATT/SR/GAW/BI-06-C GATT/SR/GAW/BV-05-C GATT/SR/GAW/BI-07-C GATT/SR/GAW/BI-08-C GATT/SR/GAW/BI-09-C GATT/SR/GAW/BI-12-C GATT/SR/GAW/BI-13-C GATT/SR/GAW/BV-06-C GATT/SR/GAW/BV-10-C GATT/SR/GAW/BV-11-C GATT/SR/GAW/BV-07-C GATT/SR/GAW/BV-08-C GATT/SR/GAW/BV-09-C GATT/SR/GAW/BI-32-C GATT/SR/GAW/BI-33-C GATT/SR/GAN/BV-01-C GATT/SR/GAN/BV-02-C GATT/SR/GAI/BV-01-C GATT/SR/GAS/BV-01-C GATT/SR/GAT/BV-01-C GATT/SR/UNS/BI-01-C GATT/SR/UNS/BI-02-C GATT/SR/GPM/BV-05-C |
|
AutoPTS Bot results: Failed testsGATT GATT/SR/GAN/BV-02-C RUNNINGGATT GATT/SR/GAS/BV-01-C UNKNOWN VERDICT: Timeout. Adjust TSPX_time_guard value if user need more time. GATT GATT/SR/GAW/BV-01-C INCONC Successful testsGATT GATT/SR/GAC/BI-01-C PASSGATT GATT/SR/GAC/BV-01-C PASS GATT GATT/SR/GAD/BV-01-C PASS GATT GATT/SR/GAD/BV-02-C PASS GATT GATT/SR/GAD/BV-03-C PASS GATT GATT/SR/GAD/BV-04-C PASS GATT GATT/SR/GAD/BV-05-C PASS GATT GATT/SR/GAD/BV-06-C PASS GATT GATT/SR/GAI/BV-01-C PASS GATT GATT/SR/GAN/BV-01-C PASS GATT GATT/SR/GAR/BI-01-C PASS GATT GATT/SR/GAR/BI-02-C PASS GATT GATT/SR/GAR/BI-04-C PASS GATT GATT/SR/GAR/BI-05-C PASS GATT GATT/SR/GAR/BI-06-C PASS GATT GATT/SR/GAR/BI-07-C PASS GATT GATT/SR/GAR/BI-08-C PASS GATT GATT/SR/GAR/BI-10-C PASS GATT GATT/SR/GAR/BI-11-C PASS GATT GATT/SR/GAR/BI-12-C PASS GATT GATT/SR/GAR/BI-13-C PASS - ERRATA https://github.com//issues/1800 GATT GATT/SR/GAR/BI-14-C PASS GATT GATT/SR/GAR/BI-16-C PASS GATT GATT/SR/GAR/BI-17-C PASS GATT GATT/SR/GAR/BI-18-C PASS GATT GATT/SR/GAR/BI-19-C PASS GATT GATT/SR/GAR/BI-21-C PASS GATT GATT/SR/GAR/BI-22-C PASS GATT GATT/SR/GAR/BI-36-C PASS GATT GATT/SR/GAR/BI-38-C PASS GATT GATT/SR/GAR/BI-42-C PASS GATT GATT/SR/GAR/BI-44-C PASS GATT GATT/SR/GAR/BI-45-C PASS - ERRATA https://github.com//issues/1800 GATT GATT/SR/GAR/BV-01-C PASS GATT GATT/SR/GAR/BV-03-C PASS GATT GATT/SR/GAR/BV-04-C PASS - ERRATA https://github.com//issues/1800 GATT GATT/SR/GAR/BV-05-C PASS GATT GATT/SR/GAR/BV-06-C PASS GATT GATT/SR/GAR/BV-07-C PASS - ERRATA https://github.com//issues/1800 GATT GATT/SR/GAR/BV-08-C PASS - ERRATA https://github.com//issues/1800 GATT GATT/SR/GAR/BV-09-C PASS GATT GATT/SR/GAR/BV-11-C PASS GATT GATT/SR/GAT/BV-01-C PASS GATT GATT/SR/GAW/BI-02-C PASS GATT GATT/SR/GAW/BI-03-C PASS GATT GATT/SR/GAW/BI-05-C PASS GATT GATT/SR/GAW/BI-06-C PASS GATT GATT/SR/GAW/BI-07-C PASS GATT GATT/SR/GAW/BI-08-C PASS GATT GATT/SR/GAW/BI-09-C PASS GATT GATT/SR/GAW/BI-12-C PASS GATT GATT/SR/GAW/BI-13-C PASS GATT GATT/SR/GAW/BI-32-C PASS GATT GATT/SR/GAW/BI-33-C PASS - ERRATA https://github.com//issues/1800 GATT GATT/SR/GAW/BV-03-C PASS GATT GATT/SR/GAW/BV-05-C PASS - ERRATA https://github.com//issues/1800 GATT GATT/SR/GAW/BV-06-C PASS GATT GATT/SR/GAW/BV-07-C PASS GATT GATT/SR/GAW/BV-08-C PASS GATT GATT/SR/GAW/BV-09-C PASS - ERRATA https://github.com//issues/1800 GATT GATT/SR/GAW/BV-10-C PASS - ERRATA https://github.com//issues/1800 GATT GATT/SR/GAW/BV-11-C PASS GATT GATT/SR/GPM/BV-05-C PASS GATT GATT/SR/UNS/BI-01-C PASS GATT GATT/SR/UNS/BI-02-C PASS |
Data packets sent over eatt chan weren't correctly truncated. Data packet is now adjusted to peer device's MTU for the channel. Fixes various GATT/SR test cases that verify support for Read Long Characteristic Value Requests, Multiple Read Characteristic Value Requests etc.
piotrnarajowski
force-pushed
the
issue1800
branch
from
ac92bda
to
57e6479
Compare
rymanluk
reviewed
Sep 21, 2024
| @@ -476,6 +476,8 @@ ble_eatt_tx(uint16_t conn_handle, uint16_t cid, struct os_mbuf *txom) | |||
| goto error; | |||
| } | |||
|
|
|||
| ble_att_truncate_to_mtu(eatt->chan, txom); | |||
There was a problem hiding this comment.
If this is happening in GATT/SR I would expect fix to be in ble_att_svr.c before ble_att_tx()
What do you think ?
KKopyscinski
approved these changes
Sep 23, 2024
sjanc
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
If we want to move out of ble_eatt_tx than we probably need to do a bit more refactor work to handle those is same way, ie currently we pass conn+cid which require lookups for chan, while we should be passing only chan (or maybe some common att and eatt bearer struct...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data packets sent over eatt chan weren't correctly truncated. Data packet is now adjusted to peer device's MTU for the channel.
Fixes various GATT/SR test cases that verify support for Read Long Characteristic Value Requests, Multiple Read Characteristic Value Requests etc.
#1800 related