nimble/audio: Add subgroups information for modify operation #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
331
to
332
| /** BIS Synchronisation of subgroups */ | ||
| uint32_t bis_sync[BLE_SVC_AUDIO_BASS_SUB_NUM_MAX]; |
There was a problem hiding this comment.
this one should not be needed, as you can pass the bis sync in subgroups[i].bis_sync instead
szymon-czapracki
force-pushed
the
scan_delegator_metadata
branch
2 times, most recently
from
d9781b9
to
d57b022
Compare
szymon-czapracki
force-pushed
the
scan_delegator_metadata
branch
2 times, most recently
from
078e6a9
to
084ca4f
Compare
| @@ -424,20 +424,20 @@ ble_svc_audio_bass_add_source(uint8_t *data, uint16_t data_len, uint16_t conn_ha | |||
| } | |||
|
|
|||
| static int | |||
| check_bis_sync(uint16_t num_subgroups, const uint32_t *bis_sync_list) | |||
| check_bis_sync(uint16_t num_subgroups, struct ble_svc_audio_bass_subgroup subgroups) | |||
There was a problem hiding this comment.
Pass subgroup pointer here:
struct ble_svc_audio_bass_subgroup *subgroups
There was a problem hiding this comment.
Typo, sorry - fixed.
This commit adds subgroups info for modify source operation. Now metadata field can be handled in scan delegator during modify procedure.
szymon-czapracki
force-pushed
the
scan_delegator_metadata
branch
from
084ca4f
to
dbfce05
Compare
|
LGTM :) |
MariuszSkamra
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subgroups info for modify source operation. Now metadata field can be handled in scan delegator during modify procedure.