Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

targets: Add sample target for controller on NRF5340 bsp #963

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

kasjer
Copy link
Contributor

@kasjer kasjer commented Apr 9, 2021

This adds sample target for building NimBLE controller (blehci app)
for Nordic NRF5340. It is used by default when combine image build
is used for nordic_pca10095 bsp.

Sample target should be used as a base for creating customized targets.
This targets nordic_pca10095_net bsp, custom targets should point to
appropriate BSP.

### Warning !!!
This target in this form is full of random settings accumulated over time
It would be good if @andrzej-kaczmarek or @sjanc of @rymanluk could
help with keeping only sensible stuff here.

@kasjer kasjer marked this pull request as draft April 9, 2021 08:21
@sjanc
Copy link
Contributor

sjanc commented Apr 9, 2021

since nrf53 has dedicated core and flash for radio, I'd go with full scale controller here, so enable all features supported:)

@kasjer
Copy link
Contributor Author

kasjer commented Apr 9, 2021

since nrf53 has dedicated core and flash for radio, I'd go with full scale controller here, so enable all features supported:)

Is there a setting like ENABLE_ALL_FEATURES: 1 to be used in this case?

@sjanc
Copy link
Contributor

sjanc commented Apr 15, 2021

MSYS_1_BLOCK_COUNT: 12
MSYS_1_BLOCK_SIZE: 292
BLE_LL_CFG_FEAT_DATA_LEN_EXT: 1
BLE_LL_CFG_FEAT_LE_2M_PHY: 1
BLE_LL_CFG_FEAT_LE_CODED_PHY: 1
BLE_LL_CFG_FEAT_LL_PRIVACY: 1
BLE_LL_CFG_FEAT_CTRL_TO_HOST_FLOW_CONTROL: 1
BLE_LL_CONN_INIT_MAX_TX_BYTES: 251
BLE_LL_CONN_INIT_SLOTS: 4
BLE_LL_DTM: 1
BLE_LL_DTM_EXTENSIONS: 1
BLE_LL_VND_EVENT_ON_ASSERT: 1
BLE_MAX_CONNECTIONS: 5
BLE_EXT_ADV: 1
BLE_EXT_ADV_MAX_SIZE: 1650
BLE_MAX_PERIODIC_SYNCS: 5
BLE_MULTI_ADV_INSTANCES: 5
BLE_PERIODIC_ADV: 1
BLE_PERIODIC_ADV_SYNC_TRANSFER: 1
BLE_HCI_TRANSPORT: nrf5340
BLE_VERSION: 51

This is config I'm using for testing, since we have plenty of RAM just for netcore we can be generous with MSYS configuration :)

@kasjer kasjer force-pushed the kasjer/nrf5340-blehci-target branch from 2806df9 to a314422 Compare April 15, 2021 12:38
@kasjer kasjer changed the title [RFC] targets: Add sample target for controller on NRF5340 bsp targets: Add sample target for controller on NRF5340 bsp Apr 15, 2021
@kasjer
Copy link
Contributor Author

kasjer commented Apr 15, 2021

Settings recommended by @sjanc applied.
Added on setting that can be removed later

   IPC_NRF5340_BUF_SZ: 1024

@kasjer kasjer marked this pull request as ready for review April 15, 2021 13:26
BLE_PERIODIC_ADV_SYNC_TRANSFER: 1
BLE_VERSION: 51

# TODO: remove once IPC fix is merged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HCI transport is fixed now and doesn't require this anymore, otherwise looks good

This adds sample target for building NimBLE controller (blehci app)
for Nordic NRF5340. It is used by default when combine image build
is used for nordic_pca10095 bsp.

Sample target should be used as a base for creating customized targets.
This targets nordic_pca10095_net bsp, custom targets should point to
appropriate BSP.
@kasjer kasjer force-pushed the kasjer/nrf5340-blehci-target branch from a314422 to d859813 Compare April 27, 2021 12:03
@apache-mynewt-bot
Copy link

Style check summary

No suggestions at this time!

@kasjer kasjer merged commit 7823a64 into apache:master Apr 27, 2021
@kasjer kasjer deleted the kasjer/nrf5340-blehci-target branch April 27, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants