Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28 failures when running java/debugger.jpda.truffle tests with GraalVM for JDK21 #6925

Open
jtulach opened this issue Jan 7, 2024 · 3 comments
Assignees
Labels
GraalVM [ci] enable GraalVM tests kind:bug Bug report or fix tests Upgrade JDK Upgrade to the JDK requirements of a module.

Comments

@jtulach
Copy link
Contributor

jtulach commented Jan 7, 2024

Apache NetBeans version

Apache NetBeans 20

What happened

I am trying to bugfix the support for debugging GraalVM languages to run properly on GraalVM for JDK21+. However the GraalVM for JDK21 has switched to so called Truffle Unchained. Due to that the tests in the debugger.jpda.truffle fails a lot. There is 28 failures out of 30 tests.

To reproduce build NetBeans and then:

netbeans$ JAVA_HOME=~/bin/graalvm-21 ant -f java/debugger.jpda.truffle test

Fixing the tests is a lot of work for an outsider. Martin @entlicher, could you look at them and adjust them to work with Truffle Unchained - I assume Truffle Unchained is responsibility of your team, so this could fit into your repsonsibilities (a bit) too.

Language / Project Type / NetBeans Component

NetBeans API Support

How to reproduce

To reproduce build NetBeans and then:

netbeans$ JAVA_HOME=~/bin/graalvm-21 ant -f java/debugger.jpda.truffle test

Did this work correctly in an earlier version?

No / Don't know

Operating System

Ubuntu

JDK

GraalVM for JDK21

Apache NetBeans packaging

Own source build

Anything else

No response

Are you willing to submit a pull request?

No

@jtulach jtulach added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Jan 7, 2024
@mbien
Copy link
Member

mbien commented Jan 7, 2024

the GraalVM job is also running on an EOL graal config:

graal: [ '22.3.1' ]

I bumped it a little bit in #6369 as intermediate step, but it needs to be moved to a supported version. Graal upgrades are a bit of a minefield #6369 (comment) - not all releases support all components.

maybe also useful as starting point, since this test is disabled:

support.stepOver(); // loading Ruby // XXX locks core to 100% in app JVM till test timeout, GraalVM 11 v22.3.1

@mbien mbien added tests GraalVM [ci] enable GraalVM tests Upgrade JDK Upgrade to the JDK requirements of a module. and removed needs:triage Requires attention from one of the committers labels Jan 7, 2024
@entlicher entlicher added this to the NB21 milestone Jan 7, 2024
@neilcsmith-net
Copy link
Member

@entlicher what's the status of this? Are you still targeting a fix for NB21, or can we bump forward to NB22?

@mbien
Copy link
Member

mbien commented Mar 18, 2024

to add a bit more info for anyone who is interested in this:

  • we might start to disable modules to be able to keep the polyglot tests active for a while longer (Exclude JDK 17+ HCL module from graalvm tests #7169)
  • graalvm deployment changed, additional languages are not installed via gu "into" the JDK, they are regular dependencies for the application (Turn all GraalVM Languages artifacts into standard Maven dependencies for Polyglot Embedders oracle/graal#6852)
    • even though this happened in GraalVM 21, 17 does not seem to have any language extensions ($bin/gu available) for some reason, I don't know why.
      edit: GraalVM 17 v22.3.1 was the last known release which had all language extensions available, tests are using this build now
      # TODO uses GraalVM 17 / 22.3.1 which is the last known release which offers all required language extensions
      # GraalVM based on JDK 21+ doesn't support the 'gu' tool anymore - extensions are now regular application dependencies
      graal: [ '22.3.1' ]
    • i am not looking forward to making lib wrapper modules for them just for the tests, maybe there is a way to avoid this and keep them in the env somehow (jlink a custom jdk for the workflow? find a dist which includes all?)
  • to make the graal tests build/run from within NB while using GraalVM CE, i had to remove the <copy todir="${jpda.classes.dir}"> sections in java/api.debugger.jpda/build.xml, java/debugger.jpda.truffle/build.xml and java/debugger.jpda/build.xml

@ebarboni ebarboni modified the milestones: NB22, NB23 Apr 19, 2024
@neilcsmith-net neilcsmith-net removed this from the NB23 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GraalVM [ci] enable GraalVM tests kind:bug Bug report or fix tests Upgrade JDK Upgrade to the JDK requirements of a module.
Projects
None yet
Development

No branches or pull requests

5 participants