-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GraalVM job to JDK 11. #6369
Conversation
... can't reproduce SIGSEGV locally what I've learned so far:
|
4fd8f03
to
506e5b8
Compare
dce1000
to
c4c19d0
Compare
update: The CI timeouts can be solved by splitting the tests up into smaller units instead of iterating through all scripts in one test method. This makes it also easier to debug, esp when CI fails. In future this can be easily updated to use parameterized tests of junit 4+ or left as is.
Initially I thought this might have a similar cause as the issue above but recompiling the ssl binding using |
cbd3524
to
8f8a30f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
would be great if any of the graal gurus could take a look at this too @sdedic @entlicher @dbalek |
f5ab910
to
2c379f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why not latest JDK 11 compatible release? Not all releases ship with all language components, tests need js, ruby, java, R and python at the same time, 22.3.1 provides this. - python launcher name change - assert that the launchers exist - assert current thread not null - add js component to graal setup - truffle API changes in unused code Explode DebugAllBaseTest into smaller units - simplifies debugging and CI log inspection - excludes side effects - more predictable timeouts, tests can now run without retry wrapper Disable PolyglotTest - test locks up once ruby is loaded, see comment Cleanup - cleanup after aa1f69f which removed the SL tests but kept some dependencies - make FeedbackSurvey less noisy on GraalVM
thanks! squashing and merging. |
2c379f8
to
0cea1f9
Compare
GraalVM 8 and 11 are EOL + PRs are blocked by the graal test job atm which runs on JDK 8 still.
lets try to upgrade to GraalVM 11 as intermediate step
meta issue #4904