New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private const properties get marked as unused when used in attributes #8244

Open

rarila opened this issue Feb 13, 2025 · 2 comments · May be fixed by #8250

Assignees

Labels

kind:bug PHP

Milestone

rarila commented Feb 13, 2025

Apache NetBeans version

Apache NetBeans 24

What happened

Current behavior

A private constant property gets marked as unused although used in class attributes:

Expected behavior

Related

Other related functionality executed on this class constant like

Find usage
Go to Deklaration
Refactor->Rename

works as expected and handles its usage inside the attribute without a problem.

Language / Project Type / NetBeans Component

PHP

How to reproduce

<?php

namespace FooBar;

use Attribute;

#[Attribute(Attribute::TARGET_CLASS)]
class SomeAttribute
{
    public function __construct(string $name) {}
}

#[SomeAttribute(name: self::NAME)]
class Test
{
    private const string NAME = 'foobar';
}

Did this work correctly in an earlier version?

No / Don't know

Operating System

Windows

JDK

jdk-23.0.2

Apache NetBeans packaging

Apache NetBeans provided installer

Anything else

No response

Are you willing to submit a pull request?

No

rarila added kind:bug needs:triage labels

troizet added the PHP label

Member

junichi11 commented Feb 15, 2025

Thank you for reporting it. Reproducible.

junichi11 removed the needs:triage label

junichi11 self-assigned this

junichi11 added this to the NB26 milestone

junichi11 added a commit to junichi11/netbeans that referenced this issue


          Fix incorrect unused constants [apacheGH-8244]

45332c9

- apache#8244
- Scan attributes after `ConstantDeclaration`s are scanned

junichi11 linked a pull request

that will close this issue

Fix incorrect unused constants [GH-8244] #8250

Open

4 tasks

junichi11 linked a pull request

that will close this issue

Fix incorrect unused constants [GH-8244] #8250

Open

4 tasks

Author

rarila commented Feb 16, 2025

@junichi11
I have to thank you for your really great work! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment