Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gson library upgraded to 2.8.9, LSP upgraded to 3.16 #3200

Merged
merged 8 commits into from
Nov 4, 2021

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Sep 30, 2021

Upgrading Gson library to the last stable version 2.8.9.
Upgrading LSP to the last stable version 3.16.

@dbalek dbalek added this to the 12.6 milestone Sep 30, 2021
@dbalek dbalek added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Sep 30, 2021
@dbalek
Copy link
Contributor Author

dbalek commented Sep 30, 2021

Do not merge this PR now. The following exception is thrown when starting IDE with the updated Gson library.

SEVERE [org.netbeans.modules.netbinox]: framework event com.google.gson type 2
org.osgi.framework.BundleException: The bundle "com.google.gson_2.8.8 [111]" could not be resolved. Reason: Missing Constraint: Import-Package: sun.misc; version="0.0.0"
	at org.eclipse.osgi.framework.internal.core.AbstractBundle.getResolverError(AbstractBundle.java:1332)
	at org.eclipse.osgi.framework.internal.core.AbstractBundle.getResolutionFailureException(AbstractBundle.java:1316)
	at org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:323)
	at org.eclipse.osgi.framework.internal.core.AbstractBundle.resume(AbstractBundle.java:390)
	at org.eclipse.osgi.framework.internal.core.Framework.resumeBundle(Framework.java:1184)
	at org.eclipse.osgi.framework.internal.core.StartLevelManager.resumeBundles(StartLevelManager.java:559)
	at org.eclipse.osgi.framework.internal.core.StartLevelManager.resumeBundles(StartLevelManager.java:544)
	at org.eclipse.osgi.framework.internal.core.StartLevelManager.incFWSL(StartLevelManager.java:457)
	at org.eclipse.osgi.framework.internal.core.StartLevelManager.doSetStartLevel(StartLevelManager.java:243)
	at org.eclipse.osgi.framework.internal.core.EquinoxLauncher.internalStart(EquinoxLauncher.java:271)
	at org.eclipse.osgi.framework.internal.core.EquinoxLauncher$2.run(EquinoxLauncher.java:246)
	at java.security.AccessController.doPrivileged(Native Method)
	at org.eclipse.osgi.framework.internal.core.EquinoxLauncher.start(EquinoxLauncher.java:244)
	at org.eclipse.osgi.launch.Equinox.start(Equinox.java:258)
	at org.netbeans.core.netigso.Netigso.start(Netigso.java:184)
	at org.netbeans.NetigsoHandle.startFramework(NetigsoHandle.java:188)
	at org.netbeans.ModuleManager.enable(ModuleManager.java:1458)
	at org.netbeans.ModuleManager.enable(ModuleManager.java:1254)
	at org.netbeans.core.startup.ModuleList.installNew(ModuleList.java:315)
	at org.netbeans.core.startup.ModuleList.trigger(ModuleList.java:251)
	at org.netbeans.core.startup.ModuleSystem.restore(ModuleSystem.java:298)
	at org.netbeans.core.startup.Main.getModuleSystem(Main.java:156)
	at org.netbeans.core.startup.Main.getModuleSystem(Main.java:125)
	at org.netbeans.core.startup.Main.start(Main.java:282)
	at org.netbeans.core.startup.TopThreadGroup.run(TopThreadGroup.java:98)```

@neilcsmith-net neilcsmith-net removed this from the 12.6 milestone Oct 13, 2021
@neilcsmith-net
Copy link
Member

Removed the milestone given the do not merge label. Add back a milestone if/when this is ready.

@JaroslavTulach
Copy link

The problem has been reported to GSON guys as google/gson#1981
The proposed fix is available as google/gson#1993

@dbalek dbalek changed the title Gson library upgraded to 2.8.8 Gson library upgraded to 2.8.8, LSP upgreded to 3.16 Nov 1, 2021
@dbalek dbalek changed the title Gson library upgraded to 2.8.8, LSP upgreded to 3.16 Gson library upgraded to 2.8.9, LSP upgreded to 3.16 Nov 1, 2021
@dbalek dbalek changed the title Gson library upgraded to 2.8.9, LSP upgreded to 3.16 Gson library upgraded to 2.8.9, LSP upgraded to 3.16 Nov 1, 2021
@dbalek dbalek requested a review from sdedic November 1, 2021 11:40
@dbalek dbalek added LSP [ci] enable Language Server Protocol tests and removed do not merge Don't merge this PR, it is not ready or just demonstration purposes. labels Nov 1, 2021
@dbalek dbalek merged commit 92c782a into apache:master Nov 4, 2021
@dbalek dbalek deleted the dbalek/gson-2.8.8 branch November 4, 2021 15:05
@KacerCZ KacerCZ added this to the NB13 milestone Nov 4, 2021
@junichi11 junichi11 added the Upgrade Library Library (Dependency) Upgrade label Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants