Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added all enterprise modules with non failing unit tests #6244

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

asbachb
Copy link
Collaborator

@asbachb asbachb commented Jul 21, 2023

No description provided.

@asbachb asbachb added CI continuous integration changes enterprise [ci] enable enterprise job labels Jul 21, 2023
@asbachb asbachb marked this pull request as ready for review July 21, 2023 18:28
@asbachb asbachb force-pushed the enable-enterprise-tests branch 3 times, most recently from 07a1497 to d25a3c0 Compare July 22, 2023 09:04
@asbachb asbachb requested a review from mbien July 22, 2023 10:15
@asbachb asbachb force-pushed the enable-enterprise-tests branch from d25a3c0 to 112f8c6 Compare July 22, 2023 10:38
@mbien
Copy link
Member

mbien commented Jul 22, 2023

I checked the log for the typical junit test summary and gradle.javaee, j2ee.ant, web.kit, web.primefaces and websvc.core don't seem to run any tests?

If there is nothing to run, lets not add it to CI until there is.

I ran the workflow two more times and all green on the enterprise job which is a good sign regarding reliability. Thanks for doing this!

@mbien mbien added this to the NB20 milestone Jul 22, 2023
@asbachb asbachb force-pushed the enable-enterprise-tests branch from 112f8c6 to f9af128 Compare July 22, 2023 16:37
@asbachb
Copy link
Collaborator Author

asbachb commented Jul 22, 2023

Double checked the modules. Removed some stuff from the test folder which seemed to be quite dead code.

@asbachb asbachb force-pushed the enable-enterprise-tests branch from f9af128 to 44c1285 Compare July 23, 2023 06:13
@matthiasblaesing
Copy link
Contributor

Would it make sense to go directly to Java 11, instead of reinstating tests, that run on a JDK we don't target? I assume, that after the 8->11 transition the next step up will not be painless, but less painful, that that.

@mbien
Copy link
Member

mbien commented Jul 24, 2023

@matthiasblaesing yeah would be great, I started the work a while ago #5166 but got stuck at some point and other higher priority tasks showed up.

What we could do though is to run all compatible tests on JDK 11 and the rest on JDK 8 within the same job.

From the old tests, only enterprise/websvc.editor.hints was failing on JDK 11 - haven't checked any modules which were added here in this PR though.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all green, going to merge this.

will move as many enterprise tests to JDK 11 as possible in a followup PR.

@mbien mbien merged commit 726bd8a into apache:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration changes enterprise [ci] enable enterprise job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants