Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code completion modified to support JDK 21 features. #6253

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Code completion modified to support JDK 21 features. #6253

merged 1 commit into from
Jul 27, 2023

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Jul 25, 2023

Code completion modified to support JDK 21 features.

@dbalek dbalek added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests JavaDoc [ci] enable java/javadoc tests and build-javadoc target labels Jul 25, 2023
@dbalek dbalek added this to the NB20 milestone Jul 25, 2023
@dbalek dbalek requested review from MartinBalin and lahodaj July 25, 2023 14:40
@dbalek dbalek self-assigned this Jul 25, 2023
MartinBalin
MartinBalin approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@MartinBalin MartinBalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thank you!

lahodaj
lahodaj approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dbalek dbalek force-pushed the dbalek/jsva-cc-21 branch from 6fcf593 to 29a9e0d Compare July 27, 2023 13:34
@dbalek dbalek merged commit 1be485f into apache:master Jul 27, 2023
@dbalek dbalek deleted the dbalek/jsva-cc-21 branch July 27, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBalin MartinBalin MartinBalin approved these changes

@lahodaj lahodaj lahodaj approved these changes

Assignees

@dbalek dbalek

Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) JavaDoc [ci] enable java/javadoc tests and build-javadoc target LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Milestone
NB20
Development

Successfully merging this pull request may close these issues.
3 participants
@dbalek @MartinBalin @lahodaj