Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "After Use Trait" to the formatting options #4685 #6467

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Add "After Use Trait" to the formatting options #4685 #6467

merged 1 commit into from
Sep 20, 2023

Conversation

junichi11
Copy link
Member

nb-php-formatting-after-use-trait-options

@junichi11
Add "After Use Trait" to the formatting options apache#4685
161f65c 
- apache#4685
- Add "After Use Trait" option
- Add unit tests
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Sep 19, 2023
@junichi11 junichi11 added this to the NB20 milestone Sep 19, 2023
@junichi11 junichi11 requested a review from tmysik September 19, 2023 09:28
@junichi11 junichi11 merged commit b0fc0d6 into apache:master Sep 20, 2023
@junichi11 junichi11 deleted the php-formatter-after-use-trait branch September 20, 2023 05:24
@terax6669 terax6669 mentioned this pull request Nov 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB20
Development

Successfully merging this pull request may close these issues.
2 participants
@junichi11 @tmysik