Add support for GlassFish 7.0.7, 7.0.8, and 7.0.9 #6542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepness
added
Java EE/Jakarta EE
mbien
reviewed
Oct 9, 2023
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java
Outdated
Show resolved
Hide resolved
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java
Outdated
Show resolved
Hide resolved
...assfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/JavaSEPlatform.java
Outdated
Show resolved
Hide resolved
mbien
reviewed
Oct 10, 2023
....tooling/src/org/netbeans/modules/glassfish/tooling/server/config/ConfigBuilderProvider.java
Outdated
Show resolved
Hide resolved
mbien
reviewed
Oct 14, 2023
Comment on lines
636
to
640
| CLSS public abstract interface java.util.Map<%0 extends java.lang.Object, %1 extends java.lang.Object> | ||
| innr public abstract interface static Entry | ||
| meth public !varargs static <%0 extends java.lang.Object, %1 extends java.lang.Object> java.util.Map<{%%0},{%%1}> ofEntries(java.util.Map$Entry<? extends {%%0},? extends {%%1}>[]) | ||
| anno 0 java.lang.SafeVarargs() | ||
| meth public abstract boolean containsKey(java.lang.Object) |
There was a problem hiding this comment.
@ebarboni @matthiasblaesing why are there JDK classes in the sig file of this module?
There was a problem hiding this comment.
the sig generator is probably not filtering out JDK classes, which means if the public API uses JDK classes in declarations, the sig changes when JDK level changes.
|
@pepness can you squash so that it is ready for merge? |
- Add new ConfigBuilderProvider for GlassFish 7.0.9 and newer with support for Java 21 - Add support for JavaSE constants up to version 22 - Bump `javac.source` and `javac.target` to version 11 for all 4 GlassFish modules `common`,`eecommon`,`javaee`, and `tooling` - Refactor creation of `ServerWizardIterator` with one private array - Use ConcurrentMap for `builders`, set initial capacity, use atomic operations `computeIfPresent` and `computeIfAbsent`, and remove some synchronized blocks because the ConcurrentHashMap implementation already use synchronized at a Node level - Generate sigtest because `check-sigtests-release` failed - Add a new method that return a numeric representation of the server version - Refactor the String representation of the Enums with a single method. Thanks to @mbien - Integrate `GlassFishVersion` enum to `ServerDetails` constructor and replace instance field `versionInt` with it - Use `GlassfishInstanceProvider` instances when creating a new `ServerDetails` enum - Refactor switch statement with single method `version.toFullInteger()` from the new `GlassFishVersion` instance - Refactor serverDetails array to one call to `ServerDetails.values()` - The `getBuilder` method can return a ConfigBuilder instance with just one atomic and non-blocking operation `computeIfAbsent`. Thanks to @mbien - Refactor long switch statement to one `if if-else else` statement - Remove unnecessary imports - Make final some instances
pepness
force-pushed
the
glassfish-overhaul
branch
from
4e53fd4 to
12031d7
Compare
mbien
approved these changes
Oct 15, 2023
pepness
changed the title
pepness
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library Notes:
NetBeans GlassFish module notes:
javac.sourceandjavac.targetto version 11 for all 4 GlassFish modulescommon,eecommon,javaee, andtoolingServerWizardIteratorwith one private arrayif if-else elsestatementbuilders, set initial capacity, use atomic operationscomputeIfPresentandcomputeIfAbsent, and remove some synchronized blocks because the ConcurrentHashMap implementation already use synchronized at a field levelNetBeans Testing:
ant -Dcluster.config=release commit-validationglassfish.common,glassfish.javaee,glassfish.tooling, andglassfish.eecommonRelease Notes