Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gradle Tooling API to 8.4 #6553

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Update Gradle Tooling API to 8.4 #6553

merged 1 commit into from
Oct 12, 2023

Conversation

lkishalmi
Copy link
Contributor

Let's move the needle.

@lkishalmi lkishalmi added the Gradle [ci] enable "build tools" tests label Oct 10, 2023
@lkishalmi lkishalmi added this to the NB20 milestone Oct 10, 2023
@mbien
Copy link
Member

mbien commented Oct 11, 2023

the last PR #6254 had one more change in extide/gradle/src/org/netbeans/modules/gradle/api/execute/GradleDistributionManager.java, please check if this is needed here too

@lkishalmi
Copy link
Contributor Author

the last PR #6254 had one more change in extide/gradle/src/org/netbeans/modules/gradle/api/execute/GradleDistributionManager.java, please check if this is needed here too

Well, not yet. Maybe I shall rename that constant as JDK_RUNTIME_COMPAT as Gradle 8.4 is not supported running on JDK 21.

@lkishalmi lkishalmi merged commit e010ac1 into apache:master Oct 12, 2023
@mbien mbien added the Upgrade Library Library (Dependency) Upgrade label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

@neilcsmith-net neilcsmith-net neilcsmith-net approved these changes

@sdedic sdedic Awaiting requested review from sdedic

Assignees
No one assigned
Labels
Gradle [ci] enable "build tools" tests Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Milestone
NB20
Development

Successfully merging this pull request may close these issues.
3 participants
@lkishalmi @mbien @neilcsmith-net