Fix and simplify handling of JSPParser classloader #7567
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classloader was reset after each invocation by calls to
resetClassLoaders
, so there is already little caching present here.The old behavior though posed a different problem: the classloaders were shared into multiple threads and calls to
resetClassLoaders
were not coordinated, so the "slower" thread could be faced with a closed classloader. For anURLClassLoader
this means, that classes already loaded work, new classes can't be loaded. This leads to difficult to debug situations.At runtime this was observed as:
Leading to errors reported in JSPs.