Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create secret rotation CronJob when running the app in the cluster #7878

Conversation

petrovic-d
Copy link
Contributor

In order to allow pulling images from Container Registry, we need to have bearer token, inside the cluster (as k8s secret), that will authorize the access to the registry.

CronJob will be created when triggering RunInClusterAction, and it will rotate secret every 1h

@jhorvath jhorvath self-requested a review October 22, 2024 13:15
@jhorvath jhorvath assigned jhorvath and petrovic-d and unassigned jhorvath Oct 22, 2024
@jhorvath jhorvath added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests enterprise [ci] enable enterprise job labels Oct 22, 2024
@jhorvath jhorvath added this to the NB24 milestone Oct 22, 2024
@apache apache locked and limited conversation to collaborators Oct 22, 2024
@apache apache unlocked this conversation Oct 22, 2024
@apache apache locked and limited conversation to collaborators Oct 22, 2024
@apache apache unlocked this conversation Oct 22, 2024
@sdedic sdedic changed the base branch from master to delivery October 22, 2024 13:43
@jhorvath jhorvath force-pushed the secret-rotation-cronjob-for-cluster-authorization branch from b2d0c72 to 64ce7e9 Compare October 24, 2024 18:31
Copy link
Contributor

@jhorvath jhorvath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jhorvath jhorvath merged commit 9f7af07 into apache:delivery Oct 25, 2024
32 checks passed
@jhorvath jhorvath deleted the secret-rotation-cronjob-for-cluster-authorization branch October 25, 2024 06:22
@neilcsmith-net
Copy link
Member

@jhorvath please follow NOTICE emails and don't merge to delivery.

https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise [ci] enable enterprise job LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants