New DevOps Toolbox Cluster #8125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkishalmi
added
do not merge
lkishalmi
requested review from
mbien,
vieiro,
matthiasblaesing and
neilcsmith-net
|
I have to ask: Why? I only see possible breakage here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting some groundwork for a new
devopstools related cluster.Initially moved the
docker.apianddocker.uifrom theidecluster here.I had one hiccup with ergonomics, as it did not created feature entry for the new cluster. after some debugging it turned out that the layer extractor does not create a
layer.xmlfor a cluster which only has the root<filesystem/>entry. That prevented theFeatureManagerto create a Feature for this cluster.It seems save one Test code the
layerbeingnullis handled in ergonomics, so I've allowed creatingFeatureInfowithnulllayer.I'd target this one for early NB26.