Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13248: Add Flow Analysis report menu to new ui #8974

Merged
merged 17 commits into from
Aug 19, 2024

Conversation

sardell
Copy link
Contributor

@sardell sardell commented Jun 18, 2024

Summary

NIFI-13248

In keeping with feature parity with the old ui, this PR adds the flow analysis report drawer and notification icon to the canvas ui.

Testing

While there are some slight style differences between the old and new ui, the behavior of the drawer and notification icon should be the same. A manual comparison between the two is probably the best way to test this PR. You can find the old UI on the 1.x maintenance branch.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@mcgilman mcgilman added the new ui Pull requests for work relating to the new user interface being developed. label Jun 18, 2024
@sardell sardell force-pushed the NIFI-13248 branch 2 times, most recently from d68804c to 1bd7dd9 Compare June 24, 2024 20:08
@sardell sardell force-pushed the NIFI-13248 branch 2 times, most recently from b8fd481 to e9ec71b Compare July 17, 2024 14:55
@sardell sardell marked this pull request as ready for review July 23, 2024 17:22
@sardell
Copy link
Contributor Author

sardell commented Jul 31, 2024

@scottyaslan Thanks for providing that helpful patch! I applied it to this PR and made a follow-up commit adding back a few missing styles. Whenever you have a chance, could you please take another look?

Copy link
Contributor

@scottyaslan scottyaslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sardell I left just a few minor comments.

Copy link
Contributor

@scottyaslan scottyaslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnk you @sardell for all the hard work here. I am +1

@scottyaslan scottyaslan merged commit 8e0c4ae into apache:main Aug 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new ui Pull requests for work relating to the new user interface being developed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants