-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-13248: Add Flow Analysis report menu to new ui #8974
Conversation
d68804c
to
1bd7dd9
Compare
b8fd481
to
e9ec71b
Compare
...ages/flow-designer/ui/canvas/header/flow-analysis-drawer/flow-analysis-drawer.component.scss
Outdated
Show resolved
Hide resolved
@scottyaslan Thanks for providing that helpful patch! I applied it to this PR and made a follow-up commit adding back a few missing styles. Whenever you have a chance, could you please take another look? |
...ages/flow-designer/ui/canvas/header/flow-analysis-drawer/flow-analysis-drawer.component.html
Outdated
Show resolved
Hide resolved
...tend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/canvas/canvas.component.html
Outdated
Show resolved
Hide resolved
...ages/flow-designer/ui/canvas/header/flow-analysis-drawer/flow-analysis-drawer.component.html
Outdated
Show resolved
Hide resolved
...pps/nifi/src/app/pages/flow-designer/ui/canvas/header/flow-status/flow-status.component.html
Outdated
Show resolved
Hide resolved
...pps/nifi/src/app/pages/flow-designer/ui/canvas/header/flow-status/flow-status.component.html
Outdated
Show resolved
Hide resolved
patch provided by @scottyaslan
patch provided by @scottyaslan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @sardell I left just a few minor comments.
...ages/flow-designer/ui/canvas/header/flow-analysis-drawer/flow-analysis-drawer.component.html
Outdated
Show resolved
Hide resolved
...ages/flow-designer/ui/canvas/header/flow-analysis-drawer/flow-analysis-drawer.component.html
Show resolved
Hide resolved
...ages/flow-designer/ui/canvas/header/flow-analysis-drawer/flow-analysis-drawer.component.html
Outdated
Show resolved
Hide resolved
...ages/flow-designer/ui/canvas/header/flow-analysis-drawer/flow-analysis-drawer.component.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thnk you @sardell for all the hard work here. I am +1
Summary
NIFI-13248
In keeping with feature parity with the old ui, this PR adds the flow analysis report drawer and notification icon to the canvas ui.
Testing
While there are some slight style differences between the old and new ui, the behavior of the drawer and notification icon should be the same. A manual comparison between the two is probably the best way to test this PR. You can find the old UI on the 1.x maintenance branch.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation