Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIFI-13968] add title tooltip for truncated attribute values #9492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[NIFI-13968] add title tooltip for truncated attribute values #9492

wants to merge 1 commit into from

Conversation

scottyaslan
Copy link
Contributor

Screenshot 2024-11-05 at 5 32 50 PM Screenshot 2024-11-05 at 5 33 13 PM

@scottyaslan scottyaslan added the new ui Pull requests for work relating to the new user interface being developed. label Nov 6, 2024
rfellows
rfellows requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@rfellows rfellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. However, it is a bit out of date. we've landed some changes in these files, adding templates to support copying of ids. we probably want to give those templates the same truncate/ellipsis treatment.

If you rebase this you will get those changes. look for formatCopyableValue and formatCopyableContentValue. just add the same to those and I'll be a 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfellows rfellows rfellows requested changes

Assignees
No one assigned
Labels
new ui Pull requests for work relating to the new user interface being developed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottyaslan @rfellows