Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14009 - Move Toolkit Client code in its own nifi-toolkit-client module #9522

Closed
wants to merge 1 commit into from

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Nov 14, 2024

Summary

NIFI-14009 - Move Toolkit Client code in its own nifi-toolkit-client module

Currently, the nifi-toolkit-cli module contains the code for a client interacting with the NiFi APIs. This code is used by the CLI itself but is also referenced in the the NiFi system test suite.

This JIRA is to move this code in its own module to have a cleaner separation. A new module nifi-toolkit-client will contain this code, and both the CLI and system test suite will depend on this new module.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring @pvillard31, having a distinct module for the REST client classes provides a helpful separation from the components specific to CLI operation. +1 merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants