Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP NUTCH-3064 Upgrade com.maxmind.geoip2:geoip2 dependency in geoip-index to v4.2.0 #825

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1180,6 +1180,7 @@
<source path="${plugins.dir}/index-basic/src/java/" />
<source path="${plugins.dir}/index-basic/src/test/" />
<source path="${plugins.dir}/index-geoip/src/java/" />
<source path="${plugins.dir}/index-geoip/src/test/" />
<source path="${plugins.dir}/index-jexl-filter/src/java/" />
<source path="${plugins.dir}/index-jexl-filter/src/test/" />
<source path="${plugins.dir}/index-links/src/java/" />
Expand Down
24 changes: 17 additions & 7 deletions conf/nutch-default.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2206,15 +2206,25 @@ CAUTION: Set the parser.timeout to -1 or a bigger value than 30, when using this
<!-- index-geoip plugin properties -->
<property>
<name>index.geoip.usage</name>
<value>insightsService</value>
<value></value>
<description>
To use the geoip-plugin you must set 'store.ip.address' to true.
A string representing the information source to be used for GeoIP information
association. Either enter 'cityDatabase', 'connectionTypeDatabase',
'domainDatabase', 'ispDatabase' or 'insightsService'. If you wish to use any one of the
Database options, you should make one of GeoIP2-City.mmdb, GeoIP2-Connection-Type.mmdb,
GeoIP2-Domain.mmdb or GeoIP2-ISP.mmdb files respectively available on the classpath and
available at runtime. Alternatively, also the GeoLite2 IP databases (GeoLite2-*.mmdb)
can be used.
lookup. Options are 'anonymous', 'asn', 'city', 'connection', 'domain',
'insights' or 'isp'.
If you wish to use any one of the Database options, you should make the relevant
*.mmdb file(s) available on the Hadoop classpath and available at runtime.
This can be achieved by adding it to `$NUTCH_HOME/conf`.
</description>
</property>

<property>
<name>index.geoip.db.file</name>
<value></value>
<description>
The GeoIP2 or GeoLite2 database file in the MMDB format. More information available at
https://support.maxmind.com/hc/en-us/articles/4408216157723-Database-Formats
This file must be available on the Hadoop classpath.
</description>
</property>

Expand Down
2 changes: 1 addition & 1 deletion src/plugin/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
<ant dir="index-anchor" target="test"/>
<ant dir="index-arbitrary" target="test"/>
<ant dir="index-basic" target="test"/>
<!--ant dir="index-geoip" target="test"/-->
<ant dir="index-geoip" target="test"/>
<ant dir="index-jexl-filter" target="test"/>
<ant dir="index-links" target="test"/>
<ant dir="index-more" target="test"/>
Expand Down
2 changes: 1 addition & 1 deletion src/plugin/index-geoip/ivy.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</publications>

<dependencies>
<dependency org="com.maxmind.geoip2" name="geoip2" rev="3.0.1">
<dependency org="com.maxmind.geoip2" name="geoip2" rev="4.2.0">
<!-- Exlude libs provided in Nutch core -->
<exclude org="com.fasterxml.jackson.core" name="jackson-annotations" />
<exclude org="com.fasterxml.jackson.core" name="jackson-databind" />
Expand Down
4 changes: 2 additions & 2 deletions src/plugin/index-geoip/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
<library name="index-geoip.jar">
<export name="*"/>
</library>
<library name="geoip2-3.0.1.jar"/>
<library name="maxmind-db-2.0.0.jar"/>
<library name="geoip2-4.2.0.jar"/>
<library name="maxmind-db-3.1.0.jar"/>
</runtime>

<requires>
Expand Down
Loading
Loading