-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to nuttx apps a simple app to test spi slave driver. #2765
Add to nuttx apps a simple app to test spi slave driver. #2765
Conversation
[Experimental Bot, please feedback here] Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. The PR summary is missing some key details. While it mentions testing the SPI slave driver, it doesn't explain how the app achieves this. Here's a breakdown of what's missing and how to improve the PR: Summary:
Impact:
Testing:
In conclusion, the PR does not fully meet the NuttX requirements. It needs significant improvements in clarity, completeness, and especially the testing section to be considered for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a commit message that describes the app
please add this new example to documentation: https://github.com/apache/nuttx/tree/master/Documentation/applications/examples so that it appears on the list here: https://nuttx.apache.org/docs/latest/applications/examples/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @FelipeMdeO :-) Please also update the documentation as requested by @raiden00pl and add commit description as requested by @jerpelea :-)
This application continuously reads the file system of the spislv. Each received message will be written to the user in hexadecimal form, and the same received data will be sent back. In this way, the user can test if their spislv driver and hardware setup are working properly before proceeding further. On a master device, using the SPI tool, when sending the message: spi exch -x 4 deadbeef The slave device will output: Slave: 4 Bytes read Value in hex form from /dev/spislv2: de ad be ef Slave: Writing value back to /dev/spislv2
182a4df
to
23b8c04
Compare
Hello @cederom, commit msg done and PR with documentation opened: apache/nuttx#14457 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you @FelipeMdeO :-)
Summary
This app can be used to test spi slave driver. Using this app will be more fast to users test and verify spi slave driver.
For instance whats happened here: apache/nuttx#13855 (comment)
Impact
No impact, new feature.
Testing
This app was used to test lower half changes done in this PR: apache/nuttx#14420