-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bp-2902} interpreters/luamodules/luv: use "depends on" instead of "select" #2907
Conversation
It has been removed a few years ago. apache/nuttx#6197
[Experimental Bot, please feedback here] Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. No, this PR does not fully meet the NuttX requirements. While it provides a summary and links a related NuttX Apps PR, it lacks crucial information. Here's what's missing:
The PR needs to be significantly revised to meet the NuttX requirements and provide sufficient context and evidence for reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jerpelea :-)
CI errors, restarted :-) |
@lupyuen could you please take a look why CI fails? I can not see any specific error reported :-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, lets fix the CI build problem first :-)
@cederom
That's because Fetch Source needs to fetch the latest source from nuttx @ releases/12.8. I discovered this when building sudo docker run \
-it \
ghcr.io/apache/nuttx/apache-nuttx-ci-linux:latest \
/bin/bash
cd
git clone https://github.com/apache/nuttx --branch releases/12.8
git clone https://github.com/jerpelea/nuttx-apps apps --branch bp-2902
pushd nuttx ; echo NuttX Source: https://github.com/apache/nuttx/tree/$(git rev-parse HEAD) ; popd
pushd apps ; echo NuttX Apps: https://github.com/apache/nuttx-apps/tree/$(git rev-parse HEAD) ; popd
cd nuttx
tools/configure.sh sim:lua
make -j
## NuttX Source: https://github.com/apache/nuttx/tree/925b8b0904dcdd8d2c36b5d0a3fe0f1960e6a5bf
## NuttX Apps: https://github.com/apache/nuttx-apps/tree/fd7b8327f2185358c6bd29018479fdcb7fe7a8bd
sudo docker run \
-it \
ghcr.io/apache/nuttx/apache-nuttx-ci-linux:latest \
/bin/bash
cd
git clone https://github.com/apache/nuttx --branch releases/12.8
git clone https://github.com/jerpelea/nuttx-apps apps --branch bp-2902
pushd nuttx ; echo NuttX Source: https://github.com/apache/nuttx/tree/$(git rev-parse HEAD) ; popd
pushd apps ; echo NuttX Apps: https://github.com/apache/nuttx-apps/tree/$(git rev-parse HEAD) ; popd
cd nuttx/tools/ci
./cibuild.sh -c -A -N -R testlist/sim-02.dat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
interpreters/luamodules/luv: use "depends on" instead of "select"
Included
#2898
Impact
RELEASE
Testing
CI