Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanftest:need enable CONFIG_LIBC_SCANSET #2914

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

crafcat7
Copy link
Contributor

Summary

When I used scanftest, I found that some of its test cases depended on the function enabled by CONFIG_LIBC_SCANSET. So I added a dependency to it to ensure the correct operation of this test case.

"",
        instead of
"   ",
        to the first argument.

Test #29 returned 0 instead of 1.
Test #29 assigned
"",
        instead of
"  q",
        to the first argument.

Test #30 returned 0 instead of 2.
Test #30 assigned
"",
        instead of
"  ",
        to the first argument.

Test #30 assigned
"",
        instead of
"Q",
        to the second argument.

Test #31 returned 0 instead of 2.
Test #31 assigned
"",
        instead of
"qwerty-",
        to the first argument.

Test #31 assigned
"",
        instead of
"QWERTY-",
        to the second argument.

Impact

Add CONFIG_LIBC_SCANSET dependency to enable the use case

Testing

Compiles fine on local code

Summary:
"",
        instead of
"   ",
        to the first argument.

Test apache#29 returned 0 instead of 1.
Test apache#29 assigned
"",
        instead of
"  q",
        to the first argument.

Test apache#30 returned 0 instead of 2.
Test apache#30 assigned
"",
        instead of
"  ",
        to the first argument.

Test apache#30 assigned
"",
        instead of
"Q",
        to the second argument.

Test apache#31 returned 0 instead of 2.
Test apache#31 assigned
"",
        instead of
"qwerty-",
        to the first argument.

Test apache#31 assigned
"",
        instead of
"QWERTY-",
        to the second argument.

Signed-off-by: chenrun1 <chenrun1@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit ee3400e into apache:master Dec 23, 2024
25 checks passed
lupyuen added a commit to lupyuen2/wip-nuttx that referenced this pull request Dec 24, 2024
`CONFIG_TESTING_SCANFTEST` is no longer needed in `rv-virt:citest` defconfig because of apache/nuttx-apps#2914

This PR excludes `CONFIG_TESTING_SCANFTEST` from `rv-virt:citest` so that CI Job `risc-v-05` will complete successfully.
xiaoxiang781216 pushed a commit to apache/nuttx that referenced this pull request Dec 24, 2024
`CONFIG_TESTING_SCANFTEST` is no longer needed in `rv-virt:citest` defconfig because of apache/nuttx-apps#2914

This PR excludes `CONFIG_TESTING_SCANFTEST` from `rv-virt:citest` so that CI Job `risc-v-05` will complete successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants