-
Notifications
You must be signed in to change notification settings - Fork 640
graphics/jpgresizetool: Add libjpeg resize tool #3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bool "JPGResizeTool" | ||
default n | ||
---help--- | ||
Libjpeg JPEG resizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All indents in Kconfig need be tabs, not spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Something is happening that turns them into spaces. I have changed them to tabs. Ill look into this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that your IDE or coding style tool is converting TAB to spaces, which is quite a common feature that doesn't work well with Kconfig files :)
Also this tool allows a denom of 16, which is not possible. Should be removed. |
Ill get back to this later this week if the tweaks are still required! |
That would be great! |
Hi @keever50 , Please add build with CMake |
7537290
to
36c9b21
Compare
@simbit18 Hi, I'm not familiar with CMake in NuttX and I'm not sure how to get this to work with my current project, so I cannot test the addition of this. I hope it is okay to leave this out for now. |
Hi @keever50, add
|
Add a libjpeg based JPEG resize tool. Simple resizer that can resize JPEGs using "jpgresize input.jpg output.jpg scale_denom(1,2,4,8) quality%". Tries to use little memory by scanning per line. Signed-off-by: Kevin Witteveen (MartiniMarter) <kevinwit1999@gmail.com>
36c9b21
to
f15e087
Compare
Thanks, done! |
Hi @keever50 , could you add some basic documentation? https://nuttx.apache.org/docs/latest/applications/graphics/index.html |
plcatool.c) | ||
endif() | ||
resize.c) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Add a libjpeg based JPEG resize tool.
Simple resizer that can resize JPEGs using
"jpgresize input.jpg output.jpg scale_denom(1,2,4,8) quality%". Tries to use little memory by scanning per line.
Impact
Allows users to quickly resize JPEG images using a simple command. Useful for in scripts to generate thumbnails or experiment with jpeg compression and size ratios.
Testing
This app is tested during the development of a project where thumbnails are generated from photos.

