Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arm/armv8-r: fix unable to switch context in ISR context #14498

Merged
merged 1 commit into from
Oct 25, 2024
Merged

arm/armv8-r: fix unable to switch context in ISR context #14498

merged 1 commit into from
Oct 25, 2024

Conversation

anchao
Copy link
Contributor

@anchao anchao commented Oct 24, 2024 •
edited
Loading

Summary

arm/armv8-r: fix unable to switch context in ISR context

Regression by #13651:

| commit 35c8c80a00a99ff0e19d51eaa74165bd830a36f8
| Author: ligd <liguiding1@xiaomi.com>
| Date:   Fri Jul 26 23:14:13 2024 +0800
|
| arch: change nxsched_suspend/resume_scheduler() called position

Signed-off-by: chao an anchao@lixiang.com

Impact

N/A

Testing

CI-CHECK

@anchao
arm/armv8-r: fix unable to switch context in ISR context
85226ef 
Regression by:
| commit 35c8c80
| Author: ligd <liguiding1@xiaomi.com>
| Date:   Fri Jul 26 23:14:13 2024 +0800
|
| arch: change nxsched_suspend/resume_scheduler() called position

Signed-off-by: chao an <anchao@lixiang.com>
@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Size: XS The size of the change in this PR is very small labels Oct 24, 2024
GUIDINGLI
GUIDINGLI requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@GUIDINGLI GUIDINGLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SMP is another questions, so you should split to another patch or PR

@anchao
Copy link
Contributor Author

anchao commented Oct 25, 2024

The SMP is another questions, so you should split to another patch or PR

You should check your submission carefully if which have any rookie mistakes.

@anchao
Copy link
Contributor Author

anchao commented Oct 25, 2024

@GUIDINGLI @hujun260

After your and hujun's changes:

  1. any irq_dispatch() call needs to properly refresh tcb to check if context switch has occurred
  2. The trace location also needs to be updated carefully
  3. new current registers must be update and return from ISR.

but your previous changes completely missed on some arm-specific chips:

image

@xiaoxiang781216 xiaoxiang781216 merged commit ea4c4ef into apache:master Oct 25, 2024
25 checks passed
@GUIDINGLI
Copy link
Contributor

@anchao
Why NOT two patches fix two questions ?

@anchao
Copy link
Contributor Author

anchao commented Oct 28, 2024

@anchao Why NOT two patches fix two questions ?

@GUIDINGLI #14514 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GUIDINGLI GUIDINGLI GUIDINGLI requested changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@acassis acassis Awaiting requested review from acassis

Assignees
No one assigned
Labels
Arch: arm Issues related to ARM (32-bit) architecture Size: XS The size of the change in this PR is very small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anchao @GUIDINGLI @xiaoxiang781216