when COMPILE_OPTIONS is not set, skip the REMOVE_ITEM in ${HOSTSRCS}, fix msvc reported case.

[jasonbu]

Summary

sim/cmake: compatible when nuttx COMPILE_OPTIONS is not set yet
#14440
when COMPILE_OPTIONS is not set, cmake will report an error:
HOST_COMPILE_OPTIONS-NOTFOUND

as we only want to do item remove. so let's skip the remove procedure at this case.

@simbit18 I did not try the win host and re-produce the problem, please help me verify if it will work, I will do verify later.

Impact

fix bug when msvc build.

Testing

CI-test & ubuntu sim:nsh.

[xiaoxiang781216]

@lupyuen could we turn on windows ci to see how much budget will be used?

[lupyuen]

@xiaoxiang781216 I'm very sorry, can we do this after 30 Oct?

Remember that ASF Infra Team is watching our GitHub Spending very closely. If we exceed their budget on 30 Oct, they will shut down GitHub Actions.

Thank you so much for your understanding, I'm very sorry we have to bear with this 🙏

[simbit18]

@jasonbu build nuttx with this PR is now OK !
Thank you

https://github.com/simbit18/nuttx-testing-ci/actions/runs/11499906609/job/32009014581

[lupyuen]

BTW we could fork the NuttX Repo to a new GitHub Org and test there: #14407

[xiaoxiang781216]

@xiaoxiang781216 I'm very sorry, can we do this after 30 Oct?

Remember that ASF Infra Team is watching our GitHub Spending very closely. If we exceed their budget on 30 Oct, they will shut down GitHub Actions.

Thank you so much for your understanding, I'm very sorry we have to bear with this 🙏

share, let's wait a moment. Thanks for your hard work to avoiding foundation turn off our ci.

[simbit18]

@xiaoxiang781216 @lupyuen I created this simple workflow to build nuttx on Windows, which starts automatically every hour, or the workflow can be activated manually. If you want, you can use it for testing in any repository.

https://github.com/simbit18/nuttx_test_pr/blob/main/.github/workflows/ci_windows.yml

this is for repository: apache/nuttx

• name: Checkout nuttx repo
  uses: actions/checkout@v4
  with:
  repository: apache/nuttx
  ref: master

For testing, just change this
example commit jasonbu

• name: Checkout nuttx repo
  uses: actions/checkout@v4
  with:
  repository: jasonbu/nuttx
  ref: sim_cmake

[lupyuen]

That's very cool thanks! :-)

[anchao]

@lupyuen could we turn on windows ci to see how much budget will be used?

@xiaoxiang781216 @xuxin930
why not enable MSVC ci on xiaomi internal server？
Shouldn't similar changes be built and validated internally before being submitted to the community？

[lupyuen]

msvc build is successful in our NuttX Mirror Repo yay! 🎉

https://github.com/NuttX/nuttx/actions/runs/11501541770

[jasonbu]

@lupyuen could we turn on windows ci to see how much budget will be used?

@xiaoxiang781216 @xuxin930 why not enable MSVC ci on xiaomi internal server？ Shouldn't similar changes be built and validated internally before being submitted to the community？

@anchao
the #14440 is created because I found the mac sim:nsh break in my personal environment.
And I totally trust the community CI. So only fix mac sim:nsh case and test by CI & local linux sim:nsh.
Also the internal server not fully running by cmake, so maybe later will able to cover mscv cmake case too.

[anchao]

@lupyuen could we turn on windows ci to see how much budget will be used?

@xiaoxiang781216 @xuxin930 why not enable MSVC ci on xiaomi internal server？ Shouldn't similar changes be built and validated internally before being submitted to the community？

@anchao the #14440 is created because I found the mac sim:nsh break in my personal environment. And I totally trust the community CI. So only fix mac sim:nsh case and test by CI & local linux sim:nsh. Also the internal server not fully running by cmake, so maybe later will able to cover mscv cmake case too.

Because setting up the MSVC environment is not a huge work, you only need to install the MSVC environment in wine or support MSVC in docker, and the compilation process does not require the support of GUI interface, CMD is enough

[xuxin930]

why not enable MSVC ci on xiaomi internal server？ Shouldn't similar changes be built and validated internally before being submitted to the community？

sure @anchao, we have a CI task for msvc, but it is daily, but there are no achieve per patch yet :-(

[anchao]

why not enable MSVC ci on xiaomi internal server？ Shouldn't similar changes be built and validated internally before being submitted to the community？

sure @anchao, we have a CI task for msvc, but it is daily, but there are no achieve per patch yet :-(

@xuxin930 @jasonbu Thank you, sounds a good start.