Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Disable the CI Build on push to master branch #14618

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

lupyuen
Copy link
Member

@lupyuen lupyuen commented Nov 3, 2024

Summary

Due to the recent cost-cutting, we are no longer running PR Merge Jobs in the nuttx and nuttx-apps repos. For this to happen, I am now running a script on my computer that will cancel any PR Merge Jobs that appear: kill-push-master.sh

This PR disables PR Merge Jobs permanently, so that we no longer need to run the script. This prevents our CI Charges from over-running, in case the script fails to operate properly.

Impact

Some NuttX Developers may wish to run the PR Merge Jobs in their repos. They will have to re-enable the job in build.yml:

on: ...
  push: ...
    branches:
      - master

Or they may rename the Default Branch from master to releases/master branch. Which will continue to execute PR Merge Jobs:

Screenshot 2024-11-04 at 5 36 15 AM

No Impact when Creating / Updating a PR: They will still undergo the same CI Checks.

No Impact to Release Branch: Merging a PR to the Release Branch will still run the PR Merge Job (exactly like today). This ensures that the Release Branch will be verified through complete CI Checks.

No Impact to Docker Builds: When the Dockerfile is updated, it will trigger the CI Workflow docker_linux.yml. Which is not affected by this PR, and will continue to run (exactly like today).

No Impact to Documentation: When the docs are updated, they are published to NuttX Website via the CI Workflow main.yml from the nuttx-website repo (scheduled daily). Which is not affected by this PR, and will continue to run (exactly like today).

Testing

Creating a PR will trigger the CI Checks: (exactly like today)

Merging a PR will no longer execute the "Merge Pull Request" job:

If we create a branch releases/master and merge a PR: CI Checks shall still execute:

Due to the [recent cost-cutting](apache#14376), we are no longer running PR Merge Jobs in the `nuttx` and `nuttx-apps` repos. For this to happen, I am now running a script on my computer that will cancel any PR Merge Jobs that appear: [kill-push-master.sh](https://github.com/lupyuen/nuttx-release/blob/main/kill-push-master.sh)

This PR disables PR Merge Jobs permanently, so that we no longer need to run the script. This prevents our CI Charges from over-running, in case the script fails to operate properly.
@github-actions github-actions bot added Area: CI Size: XS The size of the change in this PR is very small labels Nov 3, 2024
@lupyuen lupyuen marked this pull request as ready for review November 3, 2024 23:26
@xiaoxiang781216 xiaoxiang781216 merged commit da4f4e5 into apache:master Nov 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants