Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix poll notify #14670

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix poll notify #14670

wants to merge 3 commits into from
+39 −49

Commits on Nov 8, 2024

  1. fs_poll: race condition protection when modifying revents value 

    pollfd revents value is occasionally zeroed by race condition when
poll_notify() is called. This results to false timeout return value
from poll().

This behavior was found out when application called tcdrain() before
calling uart poll().

Signed-off-by: Tero Salminen <tero.salminen@unikie.com>
    @t-salminen @jlaitine
    t-salminen authored and jlaitine committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    03955cb View commit details
    Browse the repository at this point in the history

  2. fs/vfs/fs_poll.c: Only enter critical section when actually setting r… 

    …events

This is an optimization.

Signed-off-by: Jukka Laitinen <jukkax@ssrc.tii.ae>
    @jlaitine
    jlaitine committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0ab693b View commit details
    Browse the repository at this point in the history

  3. Revert "serial.c: should protect the fds when calling poll_notify" 

    This reverts commit bbb7f43.
    @jlaitine
    jlaitine committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    bf584e9 View commit details
    Browse the repository at this point in the history