Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in smp_call handle we only change TCB_FLAG_CPU_LOCKED bit of tcb->flag #14812

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

hujun260
Copy link
Contributor

Summary

in smp_call handle we only change TCB_FLAG_CPU_LOCKED bit of tcb->flag
change unrelated changes to tcb->flag fields, may cause error

Impact

smp call

Testing

ci ostest

@github-actions github-actions bot added Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Nov 15, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 15, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. The summary is insufficiently detailed. It mentions a problem and a solution, but doesn't explain why the other changes to tcb->flag are problematic or what the actual implemented change is. It needs to be more descriptive and answer all the questions posed in the template. The Impact section is far too brief and doesn't address any of the specific questions. The Testing section provides no useful information. It needs to specify the host and target details along with actual log output, not just a reference to "ci ostest."

Here's a breakdown of what's missing:

Summary:

  • Missing: What specific "unrelated changes" were happening? Why are they a problem (e.g., race conditions, incorrect state, etc.)? How does the change prevent these issues? Be explicit.

Impact:

  • Missing all details: Needs to answer all the "Impact on..." questions with specific yes/no answers and descriptions where applicable. Even if the answer is "no," explicitly state it. For example: "Impact on user: NO."

Testing:

  • Missing vital information: "ci ostest" is not sufficient. Provide details about the build host (OS, CPU architecture, compiler version). Provide details about the target (architecture, board, configuration). Most importantly, provide actual log output demonstrating the issue before the change and the corrected behavior after the change. Don't just say logs exist; show them.

reason:
change unrelated changes to tcb->flag fields, may cause error

Signed-off-by: hujun5 <hujun5@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 88b4aeb into apache:master Nov 15, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OS Components OS Components issues Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants