arch/risc-v/src/mpfs/mpfs_irq.c: Default global interrupt priorities #14841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: risc-v
|
@pussuw Happy with most of the changes you have done so far for SMP on MPFS. Just wondering if this was missed or if there was a reason to remove the defaulting of the global interrupt priorities. |
|
Sorry I have to cancel the CI Check for risc-v-05, it will run for 6 hours (then get cancelled) because of this issue: |
Clearly an error to remove it. Thanks for fixing this. I moved the per hart init to another file and must have removed this global init by accident. |
pussuw
approved these changes
Nov 19, 2024
BitBender334
force-pushed
the
bugfix/add-irq-priorities
branch
from
113a218
to
3f8ce7c
Compare
pussuw
approved these changes
Nov 19, 2024
xiaoxiang781216
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
On MPFS PolarFire, when we recently rebased to use the latest from NuttX, some of the functionality was broken. After reviewing, we noticed mpfs_irq.c no longer defaults the global interrupt priorities (removed in #14397), and this creates issues where interrupts are missed. Adding this back in.
Impact
Testing
Tested with SMP on MPFS PolarFire.