-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x86-64: Support symbol table and kasan global variables cross-border detection #14885
Conversation
2886e35
to
7a1268a
Compare
[Experimental Bot, please feedback here] This PR does not fully meet the NuttX requirements as presented. While it provides a summary of the changes, it lacks crucial details in the Impact and Testing sections. Here's a breakdown: Summary: While it mentions the what, it lacks the why and how. It needs to explain the rationale behind adding KASAN support and the specific modifications made to the link process. For example, why is KASAN support being added? Is it to address a specific memory issue or for general robustness? How does modifying the link process enable cross-border detection? What specific changes were made? A related issue number would also be helpful if one exists. Impact: This section is entirely incomplete. All points need to be addressed. KASAN will almost certainly have an impact on build size and potentially performance. It might also affect compatibility with existing code. These potential impacts need to be documented. Does enabling KASAN require any specific configuration options? Will users need to adapt their code? Does it introduce any security considerations? These questions must be answered. Testing: This section is also incomplete. It needs to specify the host operating system, CPU architecture, compiler version, and target architecture and board configuration used for testing. Critically, it needs to include actual testing logs from before and after the change, demonstrating the effectiveness of the KASAN implementation. Simply stating that changes were verified is insufficient. Concrete evidence is required. In short, the PR needs to be significantly more detailed to meet the NuttX requirements. It needs to provide a comprehensive explanation of the changes, their impact, and thorough testing results. |
…detection 1. Add kasan compilation options 2. Modify the link process to support symbol tables and kasan global variables cross-border detection Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
Why does my patch cause issues with other architectures 🧐, It shouldn't be |
it's a known issue, @lupyuen is looking at. |
Thanks @W-M-R: We just discovered a new bug in the Build Rules!
|
Presently, Simple x86 PRs will run All CI Checks (across all Architectures), as reported here: apache#14885 (comment) This PR fixes the CI Build Rules, so that Simple x86 PRs will run only One Single CI Job: `other`.
@W-M-R is this PR correct ? In the description you write about x86_64 but you modified x86 |
Presently, Simple x86 PRs will run All CI Checks (across all Architectures), as reported here: #14885 (comment) This PR fixes the CI Build Rules, so that Simple x86 PRs will run only One Single CI Job: `other`.
Sorry,#14900 ,this is the real x86-64 modification, and this patch is x86 |
Summary
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.