Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/draft stusb4500 #14894

Closed

Conversation

SimonFilgis
Copy link
Contributor

Note: Please adhere to Contributing Guidelines.

Summary

Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.

Impact

Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.

Testing

Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.

pkarashchenko and others added 7 commits October 8, 2024 22:25
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
right now it is only possible to change the delivered power on the fly
by
1. selecting PDO2 slot
2. write to POo2
3. renegotiate power by sw reset command
@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Area: Drivers Drivers issues Area: USB Board: arm Size: L The size of the change in this PR is large labels Nov 21, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 21, 2024

[Experimental Bot, please feedback here]

This PR template itself meets the NuttX requirements by explicitly laying them out and prompting the submitter to fill in the necessary information. However, a PR using this template would only meet the requirements if the submitter provides complete and accurate information in each section. Specifically, the submitter must:

  • Summary: Clearly articulate the rationale, functionality, and implementation details of the change. Including relevant issue references is crucial for traceability.
  • Impact: Thoroughly assess and document the consequences of the change across various aspects of the system. Simply stating "NO" is insufficient; justification is required even if there's no impact.
  • Testing: Provide concrete evidence of testing, including host and target details, and importantly, before/after logs demonstrating the change's effect and verifying its intended functionality.

Therefore, the template itself provides the structure for a compliant PR, but the content provided by the submitter ultimately determines whether it truly meets the NuttX requirements.

@acassis
Copy link
Contributor

acassis commented Nov 21, 2024

@SimonFilgis could you please close this on in favor of PR #14895 ? Seems like there are some artifacts from other people here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm Issues related to ARM (32-bit) architecture Area: Drivers Drivers issues Area: USB Board: arm Size: L The size of the change in this PR is large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants