Skip to content

Commit

Permalink
fix(bindings/nodejs): publish sub-package name
Browse files Browse the repository at this point in the history
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
  • Loading branch information
suyanhanx committed Mar 20, 2023
1 parent 3748c06 commit 30859f4
Show file tree
Hide file tree
Showing 8 changed files with 282 additions and 13 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/bindings_nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,7 @@ jobs:
- uses: actions/upload-artifact@v3
with:
name: bindings-windows
path: |
bindings/nodejs/*.node
bindings/nodejs/index.d.ts
bindings/nodejs/generated*.*
path: bindings/nodejs/*.node
- name: Test bindings
run: yarn test

Expand Down
2 changes: 0 additions & 2 deletions bindings/nodejs/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -191,5 +191,3 @@ Cargo.lock
!.yarn/patches
*.node
docs/

generated*.*
274 changes: 274 additions & 0 deletions bindings/nodejs/generated.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,274 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

const { existsSync, readFileSync } = require('fs')
const { join } = require('path')

const { platform, arch } = process

let nativeBinding = null
let localFileExisted = false
let loadError = null

function isMusl() {
// For Node 10
if (!process.report || typeof process.report.getReport !== 'function') {
try {
const lddPath = require('child_process').execSync('which ldd').toString().trim();
return readFileSync(lddPath, 'utf8').includes('musl')
} catch (e) {
return true
}
} else {
const { glibcVersionRuntime } = process.report.getReport().header
return !glibcVersionRuntime
}
}

switch (platform) {
case 'android':
switch (arch) {
case 'arm64':
localFileExisted = existsSync(join(__dirname, 'opendal.android-arm64.node'))
try {
if (localFileExisted) {
nativeBinding = require('./opendal.android-arm64.node')
} else {
nativeBinding = require('@opendal/lib-android-arm64')
}
} catch (e) {
loadError = e
}
break
case 'arm':
localFileExisted = existsSync(join(__dirname, 'opendal.android-arm-eabi.node'))
try {
if (localFileExisted) {
nativeBinding = require('./opendal.android-arm-eabi.node')
} else {
nativeBinding = require('@opendal/lib-android-arm-eabi')
}
} catch (e) {
loadError = e
}
break
default:
throw new Error(`Unsupported architecture on Android ${arch}`)
}
break
case 'win32':
switch (arch) {
case 'x64':
localFileExisted = existsSync(
join(__dirname, 'opendal.win32-x64-msvc.node')
)
try {
if (localFileExisted) {
nativeBinding = require('./opendal.win32-x64-msvc.node')
} else {
nativeBinding = require('@opendal/lib-win32-x64-msvc')
}
} catch (e) {
loadError = e
}
break
case 'ia32':
localFileExisted = existsSync(
join(__dirname, 'opendal.win32-ia32-msvc.node')
)
try {
if (localFileExisted) {
nativeBinding = require('./opendal.win32-ia32-msvc.node')
} else {
nativeBinding = require('@opendal/lib-win32-ia32-msvc')
}
} catch (e) {
loadError = e
}
break
case 'arm64':
localFileExisted = existsSync(
join(__dirname, 'opendal.win32-arm64-msvc.node')
)
try {
if (localFileExisted) {
nativeBinding = require('./opendal.win32-arm64-msvc.node')
} else {
nativeBinding = require('@opendal/lib-win32-arm64-msvc')
}
} catch (e) {
loadError = e
}
break
default:
throw new Error(`Unsupported architecture on Windows: ${arch}`)
}
break
case 'darwin':
localFileExisted = existsSync(join(__dirname, 'opendal.darwin-universal.node'))
try {
if (localFileExisted) {
nativeBinding = require('./opendal.darwin-universal.node')
} else {
nativeBinding = require('@opendal/lib-darwin-universal')
}
break
} catch {}
switch (arch) {
case 'x64':
localFileExisted = existsSync(join(__dirname, 'opendal.darwin-x64.node'))
try {
if (localFileExisted) {
nativeBinding = require('./opendal.darwin-x64.node')
} else {
nativeBinding = require('@opendal/lib-darwin-x64')
}
} catch (e) {
loadError = e
}
break
case 'arm64':
localFileExisted = existsSync(
join(__dirname, 'opendal.darwin-arm64.node')
)
try {
if (localFileExisted) {
nativeBinding = require('./opendal.darwin-arm64.node')
} else {
nativeBinding = require('@opendal/lib-darwin-arm64')
}
} catch (e) {
loadError = e
}
break
default:
throw new Error(`Unsupported architecture on macOS: ${arch}`)
}
break
case 'freebsd':
if (arch !== 'x64') {
throw new Error(`Unsupported architecture on FreeBSD: ${arch}`)
}
localFileExisted = existsSync(join(__dirname, 'opendal.freebsd-x64.node'))
try {
if (localFileExisted) {
nativeBinding = require('./opendal.freebsd-x64.node')
} else {
nativeBinding = require('@opendal/lib-freebsd-x64')
}
} catch (e) {
loadError = e
}
break
case 'linux':
switch (arch) {
case 'x64':
if (isMusl()) {
localFileExisted = existsSync(
join(__dirname, 'opendal.linux-x64-musl.node')
)
try {
if (localFileExisted) {
nativeBinding = require('./opendal.linux-x64-musl.node')
} else {
nativeBinding = require('@opendal/lib-linux-x64-musl')
}
} catch (e) {
loadError = e
}
} else {
localFileExisted = existsSync(
join(__dirname, 'opendal.linux-x64-gnu.node')
)
try {
if (localFileExisted) {
nativeBinding = require('./opendal.linux-x64-gnu.node')
} else {
nativeBinding = require('@opendal/lib-linux-x64-gnu')
}
} catch (e) {
loadError = e
}
}
break
case 'arm64':
if (isMusl()) {
localFileExisted = existsSync(
join(__dirname, 'opendal.linux-arm64-musl.node')
)
try {
if (localFileExisted) {
nativeBinding = require('./opendal.linux-arm64-musl.node')
} else {
nativeBinding = require('@opendal/lib-linux-arm64-musl')
}
} catch (e) {
loadError = e
}
} else {
localFileExisted = existsSync(
join(__dirname, 'opendal.linux-arm64-gnu.node')
)
try {
if (localFileExisted) {
nativeBinding = require('./opendal.linux-arm64-gnu.node')
} else {
nativeBinding = require('@opendal/lib-linux-arm64-gnu')
}
} catch (e) {
loadError = e
}
}
break
case 'arm':
localFileExisted = existsSync(
join(__dirname, 'opendal.linux-arm-gnueabihf.node')
)
try {
if (localFileExisted) {
nativeBinding = require('./opendal.linux-arm-gnueabihf.node')
} else {
nativeBinding = require('@opendal/lib-linux-arm-gnueabihf')
}
} catch (e) {
loadError = e
}
break
default:
throw new Error(`Unsupported architecture on Linux: ${arch}`)
}
break
default:
throw new Error(`Unsupported OS: ${platform}, architecture: ${arch}`)
}

if (!nativeBinding) {
if (loadError) {
throw loadError
}
throw new Error(`Failed to load native binding`)
}

const { Operator, Entry, Metadata, Lister, BlockingLister } = nativeBinding

module.exports.Operator = Operator
module.exports.Entry = Entry
module.exports.Metadata = Metadata
module.exports.Lister = Lister
module.exports.BlockingLister = BlockingLister
2 changes: 1 addition & 1 deletion bindings/nodejs/npm/darwin-x64/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@
"engines": {
"node": ">= 10"
}
}
}
2 changes: 1 addition & 1 deletion bindings/nodejs/npm/linux-x64-gnu/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
"libc": [
"glibc"
]
}
}
2 changes: 1 addition & 1 deletion bindings/nodejs/npm/win32-x64-msvc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@
"engines": {
"node": ">= 10"
}
}
}
5 changes: 4 additions & 1 deletion bindings/nodejs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
"description": "Open Data Access Layer: Access data freely, painlessly, and efficiently",
"repository": "git@github.com/apache/incubator-opendal.git",
"napi": {
"name": "opendal"
"name": "opendal",
"package": {
"name": "@opendal/lib"
}
},
"keywords": [
"api",
Expand Down
3 changes: 0 additions & 3 deletions licenserc.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ excludes = [
# Python binding related files
"**/venv/**",

# Nodejs binding related files
"bindings/nodejs/generated*.*",

# Website generated files
"website/build",
"website/.docusaurus",
Expand Down

0 comments on commit 30859f4

Please sign in to comment.