ci(bindings/nodejs): Support aarch64-apple-darwin

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
apache · Mar 27, 2023 · 617ad9c · 617ad9c
1 parent 1d563b4
commit 617ad9c
Show file tree

Hide file tree

Showing 5 changed files with 48 additions and 4 deletions.
diff --git a/.github/workflows/bindings_nodejs.yml b/.github/workflows/bindings_nodejs.yml
@@ -144,14 +144,30 @@ jobs:
       matrix:
         node:
           - '18'
+        settings:
+          - target: x86_64-apple-darwin
+            build: |
+              yarn build
+              strip -x *.node
+          - target: aarch64-apple-darwin
+            build: |
+              sudo rm -Rf /Library/Developer/CommandLineTools/SDKs/*;
+              export CC=$(xcrun -f clang);
+              export CXX=$(xcrun -f clang++);
+              SYSROOT=$(xcrun --sdk macosx --show-sdk-path);
+              export CFLAGS="-isysroot $SYSROOT -isystem $SYSROOT";
+              yarn build --target aarch64-apple-darwin
+              strip -x *.node
     runs-on: macos-latest
-    if: "startsWith(github.ref, 'refs/tags/')"
+#    if: "startsWith(github.ref, 'refs/tags/')"
 
     # Notes: this defaults only apply on run tasks.
     defaults:
       run:
         working-directory: "bindings/nodejs"
 
+    name: macos - ${{ matrix.settings.target }}
+
     steps:
       - uses: actions/checkout@v3
       - name: Setup node
@@ -165,10 +181,11 @@ jobs:
       - name: Install dependencies
         run: yarn install
       - name: Build
-        run: yarn build
+        run: ${{ matrix.settings.build }}
+        shell: bash
       - uses: actions/upload-artifact@v3
         with:
-          name: bindings-macos
+          name: bindings-macos-${{ matrix.settings.target }}
           path: bindings/nodejs/*.node
       - name: Test bindings
         run: yarn test

diff --git a/bindings/nodejs/index.d.ts b/bindings/nodejs/index.d.ts
@@ -127,7 +127,7 @@ export class PresignedRequest {
   /**
    * Returns the headers of this request.
    *
-   * The key of the map is the header name, and the value is the header value AS bytes.
+   * The key of the map is the header name, and the value is the header value.
    */
   headers(): Record<string, string>
 }
diff --git a/bindings/nodejs/npm/darwin-arm64/README.md b/bindings/nodejs/npm/darwin-arm64/README.md
@@ -0,0 +1,3 @@
+# `@opendal/lib-darwin-arm64`
+
+This is the **aarch86_64-apple-darwin** binary for `opendal`
diff --git a/bindings/nodejs/npm/darwin-arm64/package.json b/bindings/nodejs/npm/darwin-arm64/package.json
@@ -0,0 +1,18 @@
+{
+  "name": "@opendal/lib-darwin-arm64",
+  "version": "0.30.4",
+  "os": [
+    "darwin"
+  ],
+  "cpu": [
+    "arm64"
+  ],
+  "main": "opendal.darwin-arm64.node",
+  "files": [
+    "opendal.darwin-arm64.node"
+  ],
+  "license": "Apache-2.0",
+  "engines": {
+    "node": ">= 10"
+  }
+}
diff --git a/bindings/nodejs/package.json b/bindings/nodejs/package.json
@@ -11,6 +11,12 @@
     "name": "opendal",
     "package": {
       "name": "@opendal/lib"
+    },
+    "triples": {
+      "defaults": true,
+      "additional": [
+        "aarch64-apple-darwin"
+      ]
     }
   },
   "keywords": [