refactor(services/azblob): Adopt new reqsign (#1902)

* refactor: Change presign to async for future refactor Signed-off-by: Xuanwo <github@xuanwo.io> * Fix unit test Signed-off-by: Xuanwo <github@xuanwo.io> * refactor(services/azblob): Adopt new reqsign Signed-off-by: Xuanwo <github@xuanwo.io> --------- Signed-off-by: Xuanwo <github@xuanwo.io>
apache · Apr 11, 2023 · aefe767 · aefe767
1 parent 9cd3ca1
commit aefe767
Show file tree

Hide file tree

Showing 9 changed files with 431 additions and 329 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/core/Cargo.toml b/core/Cargo.toml
@@ -118,7 +118,9 @@ redis = { version = "0.22", features = [
  "tokio-comp",
  "connection-manager",
 ], optional = true }
+# NOTE: we keep this for service migration one by one. And finally we will replace reqsign by v0.9.
 reqsign = "0.8.5"
+reqsign_0_9 = { package = "reqsign", git = "https://github.com/Xuanwo/reqsign", rev = "c1e44223a984a612b63c80ee8092f0c089ff62bd" }
 reqwest = { version = "0.11.13", features = [
  "multipart",
  "stream",

diff --git a/core/src/raw/http_util/error.rs b/core/src/raw/http_util/error.rs
@@ -94,6 +94,16 @@ pub fn new_request_build_error(err: http::Error) -> Error {
  .set_source(err)
 }
 
+/// Create a new error happened during signing request.
+pub fn new_request_credential_error(err: anyhow::Error) -> Error {
+ Error::new(
+ ErrorKind::Unexpected,
+ "loading credentail to sign http request",
+ )
+ .with_operation("reqsign::LoadCredential")
+ .set_source(err)
+}
+
 /// Create a new error happened during signing request.
 pub fn new_request_sign_error(err: anyhow::Error) -> Error {
  Error::new(ErrorKind::Unexpected, "signing http request")

diff --git a/core/src/raw/http_util/mod.rs b/core/src/raw/http_util/mod.rs
@@ -48,6 +48,7 @@ pub use uri::percent_encode_path;
 
 mod error;
 pub use error::new_request_build_error;
+pub use error::new_request_credential_error;
 pub use error::new_request_sign_error;
 pub use error::parse_error_response;
 pub use error::ErrorResponse;