Skip to content

Commit

Permalink
ci(nodejs): Disable services-all on windows (#4762)
Browse files Browse the repository at this point in the history
ci: Disable services-all on windows

Signed-off-by: Xuanwo <github@xuanwo.io>
  • Loading branch information
Xuanwo authored Jun 18, 2024
1 parent 75d796c commit c1ca806
Showing 1 changed file with 18 additions and 17 deletions.
35 changes: 18 additions & 17 deletions .github/workflows/ci_bindings_nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,13 @@ jobs:
run: cargo test --no-fail-fast

linux:
name: linux - ${{ matrix.settings.target }}
runs-on: ubuntu-latest
if: "startsWith(github.ref, 'refs/tags/')"
# Notes: this defaults only apply on run tasks.
defaults:
run:
working-directory: "bindings/nodejs"
env:
NAPI_FEATURES: services-all
strategy:
Expand Down Expand Up @@ -129,13 +134,6 @@ jobs:
# change owner to current user
sudo chown -R 1001:121 *.node
# Notes: this defaults only apply on run tasks.
defaults:
run:
working-directory: "bindings/nodejs"

name: linux - ${{ matrix.settings.target }}

steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
Expand All @@ -161,10 +159,15 @@ jobs:
path: bindings/nodejs/*.node

windows:
name: windows - ${{ matrix.settings.target }}
runs-on: windows-latest
if: "startsWith(github.ref, 'refs/tags/')"
env:
NAPI_FEATURES: services-all

# Windows built failed with services-all
# Wait for https://github.com/apache/opendal/issues/4761
# env:
# NAPI_FEATURES: services-all

strategy:
matrix:
settings:
Expand All @@ -180,7 +183,7 @@ jobs:
run:
working-directory: "bindings/nodejs"

name: windows - ${{ matrix.settings.target }}


steps:
- uses: actions/checkout@v4
Expand All @@ -206,8 +209,13 @@ jobs:
path: bindings/nodejs/*.node

macos:
name: macos - ${{ matrix.settings.target }}
runs-on: macos-latest
if: "startsWith(github.ref, 'refs/tags/')"
# Notes: this defaults only apply on run tasks.
defaults:
run:
working-directory: "bindings/nodejs"
env:
NAPI_FEATURES: services-all
strategy:
Expand All @@ -230,13 +238,6 @@ jobs:
pnpm build
strip -x *.node
# Notes: this defaults only apply on run tasks.
defaults:
run:
working-directory: "bindings/nodejs"

name: macos - ${{ matrix.settings.target }}

steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
Expand Down

0 comments on commit c1ca806

Please sign in to comment.