Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Infer storage name based on endpoint. #1519

Closed
xinlifoobar opened this issue Mar 8, 2023 · 4 comments
Closed

feat: Infer storage name based on endpoint. #1519

xinlifoobar opened this issue Mar 8, 2023 · 4 comments
Assignees

Comments

@xinlifoobar
Copy link
Contributor

xinlifoobar commented Mar 8, 2023

The AzBlob backend today requires the user to provide the endpoint and storage account name at the same time. While this could be improved by inferring the storage name from an endpoint or endpoint by the storage name and cloud name as the default behaviour. Given the naming conversion azure blob resource uri syntax, e.g., https://<accountName>.blob.core.windows.net.

Ref code: https://github.com/datafuselabs/opendal/blob/main/src/services/azblob/backend.rs#L188

@Xuanwo
Copy link
Member

Xuanwo commented Mar 8, 2023

Indeed, we can infer the account name if endpoint endswith blob.core.windows.net. Do you want to submit a PR for this?

@xinlifoobar
Copy link
Contributor Author

Sure, I could create a PR for this.

@Xuanwo
Copy link
Member

Xuanwo commented Mar 8, 2023

Great! I have assigned this issue to you.

@suyanhanx
Copy link
Member

Sounds Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants