feat: Infer storage name based on endpoint #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Mar 10, 2023
Xuanwo
reviewed
Mar 10, 2023
You are correct. We should allow for an empty account name. I apologize for the incorrect review. Please infer the account name only from the endpoint when the user inputs the account key, but the account name is empty. |
This reverts commit 7316bd1.
|
@Xuanwo Just reverted the last change. The infer should happen at the time when the account_key/sas(for blob only) is provided while there is no account name. |
Xuanwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Infer storage account name based on endpoint uri for known patterns.
Issue: #1519