Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issues of async reqsign migration #1907

Closed
6 tasks done
Xuanwo opened this issue Apr 11, 2023 · 4 comments
Closed
6 tasks done

Tracking issues of async reqsign migration #1907

Xuanwo opened this issue Apr 11, 2023 · 4 comments

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Apr 11, 2023 •
edited
Loading

This issue is used to track our async reqsign migration. See #1902 for example.

We should:

  • Add XxxCore which contains signer and other config values
  • All other struct like Backend, Pager, Writer should hold Arc<XxxCore>
  • All function should be refactored.

Tasks
@Xuanwo

This comment was marked as resolved.

Sign in to view
@suyanhanx

This comment was marked as resolved.

Sign in to view
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 11, 2023 •
edited
Loading

reqsign used to use ureq to do blocking request for auth. But we find it could block the entire tokio runtime if there are many concurrent blocking request. So we change the auth API to async which powered by reqwest.

Along with this change, reqsign did some refactor to polish the public API.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 12, 2023

Thanks @suyanhanx for your help!

@Xuanwo Xuanwo closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xuanwo @suyanhanx