Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(services/gcs): Migrate to async reqsign #1906

Merged
merged 2 commits into from
Apr 11, 2023
Merged

refactor(services/gcs): Migrate to async reqsign #1906

merged 2 commits into from
Apr 11, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 11, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@suyanhanx
Copy link
Member

May we open an issue to track this? And introduce this refactor process.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 11, 2023

May we open an issue to track this? And introduce this refactor process.

Great idea! Sometimes, I forget that I am not alone and have strong opendal community behind me!

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 5721bbd into main Apr 11, 2023
@Xuanwo Xuanwo deleted the refactor-gcs branch April 11, 2023 09:22
wcy-fdu pushed a commit to wcy-fdu/opendal that referenced this pull request Apr 12, 2023
* refactor(services/gcs): Migrate to async reqsign

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix test

Signed-off-by: Xuanwo <github@xuanwo.io>

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants