Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the LoggingLayer API #2090

Closed
killme2008 opened this issue Apr 23, 2023 · 0 comments · Fixed by #2160
Closed

Improve the LoggingLayer API #2090

killme2008 opened this issue Apr 23, 2023 · 0 comments · Fixed by #2160

Comments

@killme2008
Copy link
Contributor

killme2008 commented Apr 23, 2023 •
edited
Loading

When configuring the logging level in LoggingLayer, we have to add the log crate to our project because of log::Level. It's a little annoying.

As discussed in #2089 , @Xuanwo proposes to change the API into with_error_level(lvl: Option<&str>). It would be great.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(layers/logging): parsing level str PsiACE/opendal
1 participant
@killme2008