chore: improve LoggingLayer docs and pub use log::Level #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
requested review from
Xuanwo,
PsiACE,
ClSlaid and
sundy-li
as code owners
killme2008
force-pushed
the
feature/improve-logging-layer-docs
branch
from
aeb4503
to
28144f0
Compare
Xuanwo
reviewed
Apr 23, 2023
killme2008
force-pushed
the
feature/improve-logging-layer-docs
branch
from
28144f0
to
c983fea
Compare
Xuanwo
approved these changes
Apr 23, 2023
|
Great, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small changes:
LoggingLayerdocs, close Annoying log when reading a file not exists #1820log::Levelinlayers::logging. It can simplify the user's dependencies, they don't have to depend on thelogcrate directly when configuringLoggingLayer.