Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issues of RFC-2133: Append API #2163

Closed
10 of 11 tasks
ShadowySpirits opened this issue Apr 29, 2023 · 11 comments
Closed
10 of 11 tasks

Tracking issues of RFC-2133: Append API #2163

ShadowySpirits opened this issue Apr 29, 2023 · 11 comments

Comments

@ShadowySpirits
Copy link
Member

ShadowySpirits commented Apr 29, 2023

@suyanhanx
Copy link
Member

I found that there are two different kinds of append, depending on whether the append operation can automatically create a new object that does not exist.

oss creates them automatically, while azblob does not. This makes it possible for the append operation to be inconsistent.

How do we deal with this problem?

  1. Not to handle it, just report an error if it cannot be created. This prevents the user from creating an append-type blob through us.
  2. Add a new method to the appender, such as init, so that the user can add a blob of this type.

WDYT?

cc @Xuanwo

references:

@Xuanwo
Copy link
Member

Xuanwo commented May 18, 2023

I found that there are two different kinds of append, depending on whether the append operation can automatically create a new object that does not exist.

It's not a big different. append should creat new object if it doesn't exist.

2. Add a new method to the appender, such as init, so that the user can add a blob of this type.

No, we don't need it. To start an append process, we will need to head it first:

  • If the blob exists, we should record it's current pos (so that we can append to it)
  • If the blob doesn't exist, we should create it first.

@suyanhanx
Copy link
Member

  • If the blob doesn't exist, we should create it first.

So we can specifically handle the not existing error in our implementation.

@silver-ymz
Copy link
Member

Sftp services also support append API natively. Do I need to implement it?

@suyanhanx
Copy link
Member

Sftp services also support append API natively. Do I need to implement it?

You can have a try if you want to do it. Have fun!

@suyanhanx
Copy link
Member

Have implemented.

@Xuanwo Xuanwo reopened this May 24, 2023
@Xuanwo
Copy link
Member

Xuanwo commented May 24, 2023

I'm guessing obs, cos, wasabi has been missed.

@Xuanwo
Copy link
Member

Xuanwo commented May 24, 2023

I'm guessing obs, cos, wasabi has been missed.

It's ok to create seperate issues for services and leave this tracking issue closed.

@suyanhanx
Copy link
Member

Already reopened. 🤣 I'll check them.

@xyjixyjixyji
Copy link
Contributor

I would like to implement the wasabi part.

@infdahai
Copy link
Contributor

@Xuanwo I would take the obs part.

@Xuanwo Xuanwo closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@Xuanwo @suyanhanx @infdahai @ShadowySpirits @silver-ymz @xyjixyjixyji and others