Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services/oss): add append support #2279

Merged
merged 6 commits into from
May 23, 2023
Merged

feat(services/oss): add append support #2279

merged 6 commits into from
May 23, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented May 22, 2023

Add append support for OSS.

core/src/services/oss/core.rs Outdated Show resolved Hide resolved
core/src/services/oss/core.rs Outdated Show resolved Hide resolved
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@Xuanwo

This comment was marked as off-topic.

@Xuanwo
Copy link
Member

Xuanwo commented May 22, 2023

Seems our layered accessor is not implemented correctly.

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review May 23, 2023 02:56
@suyanhanx
Copy link
Member Author

Seems our layered accessor is not implemented correctly.

Just I missed adding the append method. 🤣

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 01e70a6 into main May 23, 2023
@Xuanwo Xuanwo deleted the append-oss branch May 23, 2023 03:19
@Xuanwo Xuanwo mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants