Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings/cpp: Cmake with a version greater than 3.24 may issue a warning. #5337

Closed
Xuanwo opened this issue Nov 18, 2024 · 0 comments · Fixed by #5346
Closed

bindings/cpp: Cmake with a version greater than 3.24 may issue a warning. #5337

Xuanwo opened this issue Nov 18, 2024 · 0 comments · Fixed by #5346

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Nov 18, 2024

Cmake with a version greater than 3.24 may issue a warning.

CMake Warning (dev) at /usr/share/cmake-3.25/Modules/FetchContent.cmake:1279 (message):
  The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is
  not set.  The policy's OLD behavior will be used.  When using a URL
  download, the timestamps of extracted files should preferably be that of
  the time of extraction, otherwise code that depends on the extracted
  contents might not be rebuilt if the URL changes.  The OLD behavior
  preserves the timestamps from the archive instead, but this is usually not
  what you want.  Update your project to the NEW behavior or specify the
  DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this
  robustness issue.
Call Stack (most recent call first):
  CMakeLists.txt:121 (FetchContent_Declare)

We can fix it in another PR, for example by adding the following to CmakeLists.txt

if (POLICY CMP0135)
    cmake_policy(SET CMP0135 NEW)
endif ()

Originally posted by @silver-ymz in #5195 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant